Skip to content

In New DB Wizard, choosing Advanced settings changes transform rounds to 1 round #2806

@sts10

Description

@sts10

Expected Behavior

In the New Database Wizard, at the "Encryption Settings" step, if users do NOT go into "Advanced Settings", Decryption Time is set to a default of 1.0 seconds. I assume a benchmark test is performed immediately after the user clicks "Continue". That's great.

I would expect that if a curious user clicks "Advanced Settings", that that 1.0 second default would persist into the Advanced Settings menu.

Current Behavior

NOTE: I believe it only happens on a first run through the Wizard. I could reproduce when I uninstalled and re-installed KeePassXC 2.4.0 (which I did via snap).

  1. Get to Encryption Settings
  2. Click "Advanced Settings"
  3. Default number of transform rounds is now 1 transform round (not a 1-second benchmark -- just 1 round).
  4. Don't change anything, just click continue (think a curious but inexperienced user freaking out a little)
  5. Database is created with only 1 transform round of security.

Screenshot_20190319_224332

Possible Solution

  1. Perform the 1-second benchmark when user clicks "Advanced Settings".
  2. Make the result of that benchmark the default number of transform rounds in the Advanced Settings menu.

OR

Hard-code a default number of transform rounds for the Advanced Settings menu. Something conservatively low, but acceptable. My guess would be 5? 10? 15? Here I defer to experts, but 1 feels low?

Steps to Reproduce

  1. Launch the New Database Wizard for the first time (after a fresh install of 2.4.0 -- remove and reinstall if necessary)
  2. Get to Encryption Settings
  3. Click "Advanced Settings"
  4. Default number of transform rounds is now 1 round (not 1 second benchmark -- just 1 round).
  5. Don't change anything, just click continue (think a curious but inexperienced user)
  6. User gets a database with 1 transform round of security.

Context

As noted, curious-but-inexperienced user may end up with a 1-round database.

I'll separately note that this may only be an issue with Snap installations of KeePassXC (see debug info below).

Debug Info

KeePassXC - Version 2.4.0
Revision: c51752d
Distribution: Snap

Libraries:

  • Qt 5.9.5
  • libgcrypt 1.8.1

Operating system: Ubuntu Core 18
CPU architecture: x86_64
Kernel: linux 4.18.0-16-generic

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • SSH Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions