Skip to content

Use Custom Icon multi-selector does not show correct number of icons #2251

@Sacha00Z

Description

@Sacha00Z

When editing an entry (x), and after pressing "Download Favicon", a successful download completes. The list of custom icons only shows favicons 1 to favicons n-1. The last downloaded favicon n is excluded from the list.
If you then create a new entry (y), and press "Download Favicon", the favicon for entry x appears (instead of the favicon for entry y)
This has all the hallmarks of an array length calculation issue for the number of items to show in the "use custom icon" list.

Expected Behavior

When I press "Download Favicon" the favicon for my current site should be displayed in the "custom icon" list.

Current Behavior

When I press "Download Favicon" the favicon for my previously edited site is added to the end of the "custom icon" list.

Possible Solution

This looks like a for loop needs to execute one more time.

Steps to Reproduce (for bugs)

  1. Edit an entry for google.com, go to "icon", and hit "Download Favicon"
  2. Create a new entry for yahoo.com, go to "icon", and hit "Download Favicon"
  3. Note that only the google favicon is available.

Context

I originally created my kdbx in KeePass and used a plugin to download favicons (can't remember which one). I have since migrated to KeePassXC. I run it on various Windows 10 machines, and also on Linux, synchronising via OneDrive.

Debug Info

KeePassXC - Version 2.3.4
Revision: 6fe821c

Libraries:

  • Qt 5.11.1
  • libgcrypt 1.8.3

Operating system: Windows 10 (10.0)
CPU architecture: x86_64
Kernel: winnt 10.0.17134

Enabled extensions:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey

Libraries:

  • LIBS

Operating system: OS Windows 10
CPU architecture: ARCH x64
Kernel: KERNEL

Enabled extensions:

  • EXTENSIONS

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions