Skip to content

KeePassHTTP: Invalid URLs in title/URL leads to false positives #1340

@yan12125

Description

@yan12125

Expected Behavior

The KeePassHTTP plugin returns matched entries only

Current Behavior

When the title or URL field in an entry contains an invalid URL, the entry is returned

Possible Solution

Reject invalid URLs in Service::matchUrlScheme() (untested)

Steps to Reproduce (for bugs)

  1. Create an entry with title https://example.com foobar. Note that there's a space before foobar
  2. Check matched entries from KeePassHTTP in browsers

Context

This is a following up of #1017

Debug Info

KeePassXC - Version 2.2.4
Revision: ad8fca2

Libraries:

  • Qt 5.10.0
  • libgcrypt 1.8.2

Operating system: Arch Linux
CPU architecture: x86_64
Kernel: linux 4.14.9-1-ARCH

Enabled extensions:

  • KeePassHTTP
  • Auto-Type
  • YubiKey
  • SSH Agent

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions