Skip to content

Remove lock file support #1002

@scic

Description

@scic

KeepassXC creates a lock file when a database was opened. If another user opens the same database he gets a warning that another user has this file opened.
In the meanwhile KeepassXC implemented:

  • Merge support
  • Only one instance of KeepassXC can be opened on the same computer

Thus I think no such lock file is necessary anymore.

Expected Behavior

Multiple users can concurrently open a file on a network share (NFS, SMB, ...) without being shown a dialog where they are informed that other users have opened the file and how to resolve this issue.
The already implemented database merge feature should already be sufficient to handle concurrent edits.

Current Behavior

A dialog is shown with the options:

  • Don't open
  • Open anyways
  • Open read only

Possible Solution

Remove the lock file feature altogether.
I think the feature was introduced 2 years ago with this commit: 05b5446

Context

We share database files over a network share. The database is rarely edited anyways. But read (opened) very often by multiple users concurrently. The dialog just annoys users and it leads to confusion what to do.

Removing this feature would also solve #275

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions