This repository was archived by the owner on Dec 9, 2021. It is now read-only.
Show the autotype sequence when inheriting from default#103
Open
cbrunet wants to merge 2 commits intokeepassx:masterfrom
cbrunet:ShowAutotypeSequence
Open
Show the autotype sequence when inheriting from default#103cbrunet wants to merge 2 commits intokeepassx:masterfrom cbrunet:ShowAutotypeSequence
cbrunet wants to merge 2 commits intokeepassx:masterfrom
cbrunet:ShowAutotypeSequence
Conversation
3 tasks
ghost
reviewed
Aug 19, 2018
ghost
left a comment
There was a problem hiding this comment.
don't use this - it segfaults (see comments which I added to the respective lines below)
| QString Group::effectiveAutoTypeSequence() const | ||
| { | ||
| QString sequence; | ||
| const Group* grp = this; |
| QString sequence; | ||
| const Group* grp = this; | ||
| do { | ||
| if (grp->autoTypeEnabled() == Group::Disable) { |
There was a problem hiding this comment.
//and it segfaults here but not because of that function call, but because of Group::Disable (and because this is freakin null here!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, it is easier to start from current autotype sequence when modifying it.