Document the support for different metric types#657
Merged
zroubalik merged 4 commits intokedacore:mainfrom Mar 30, 2022
Merged
Conversation
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4 tasks
zroubalik
reviewed
Feb 14, 2022
arschles
reviewed
Feb 15, 2022
Contributor
arschles
left a comment
There was a problem hiding this comment.
Looks good. I left a small suggestion, but I don't think that's strictly necessary for this PR to be merged.
b060d67 to
9e2e59e
Compare
arschles
suggested changes
Feb 24, 2022
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
9e2e59e to
da5dc85
Compare
arschles
approved these changes
Mar 2, 2022
tomkerkhove
approved these changes
Mar 3, 2022
zroubalik
approved these changes
Mar 3, 2022
Member
zroubalik
left a comment
There was a problem hiding this comment.
LGTM, thanks for the example
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
arschles
approved these changes
Mar 28, 2022
JorTurFer
approved these changes
Mar 29, 2022
Signed-off-by: amirschw <24677563+amirschw@users.noreply.github.com>
zroubalik
approved these changes
Mar 30, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR in the keda repo: kedacore/keda#2309.
Checklist
Signed-off-by: amirschw 24677563+amirschw@users.noreply.github.com
Relates to kedacore/keda#2030