Skip to content

fix: timeout should be of type string | unless it would not be applie…#1612

Merged
JorTurFer merged 9 commits intokedacore:mainfrom
darmond157:fix-timeout-syntax-error
Aug 19, 2025
Merged

fix: timeout should be of type string | unless it would not be applie…#1612
JorTurFer merged 9 commits intokedacore:mainfrom
darmond157:fix-timeout-syntax-error

Conversation

@darmond157
Copy link
Contributor

fix: timeout value in prometheus trigger should be of type string. unless it would not be applied in manifests using kubectl.

prometheus doc of directory content/docs/2.17/scalers/prometheus.md has been updated.
timeout: 1000 cannot be applied by kubectl. it should be timeout: "1000"

@darmond157 darmond157 requested a review from a team as a code owner August 18, 2025 11:43
@netlify
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 67d877e
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/68a3745ed990bc000850e436
😎 Deploy Preview https://deploy-preview-1612--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! Could you update other versions as well?

@darmond157
Copy link
Contributor Author

darmond157 commented Aug 18, 2025

nice catch! Could you update other versions as well?

of course. i will do that immediately.
timeout is only in versions of 2.17, 2.18.
should it be added to previous versions?

@JorTurFer
Copy link
Member

No no, just updating the versions where timeout exists.
Please fix DCO check too -> https://github.com/kedacore/keda-docs/pull/1612/checks?check_run_id=48299823862

rickbrouwer and others added 8 commits August 18, 2025 19:22
* Remove deprecated tls setting IBMMQ

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Remove deprecate type setting CPU/MEM

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

* Remove deprecated type setting CPU/MEM

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

---------

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
* fix: Remove non-canonical pages from sitemap

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix: Remove non-canonical pages from sitemap

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

---------

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
…core#1605)

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
…edacore#1599)

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
)

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
Signed-off-by: semihbkgr <buyukgungorsemih@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
….com> (kedacore#1604)

Signed-off-by: Harry Lincoln <harry.lincoln@container-solutions.com>
Signed-off-by: darmond <bardiarezaeikalantari@gmail.com>
@darmond157 darmond157 force-pushed the fix-timeout-syntax-error branch from 89deb92 to 7935846 Compare August 18, 2025 15:52
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙇

@JorTurFer JorTurFer enabled auto-merge (squash) August 19, 2025 08:12
@JorTurFer JorTurFer merged commit b1f3446 into kedacore:main Aug 19, 2025
8 checks passed
@darmond157 darmond157 deleted the fix-timeout-syntax-error branch August 19, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants