Skip to content

feat: add fallback support for value metric type#1606

Merged
zroubalik merged 1 commit intokedacore:mainfrom
y-rabie:support-fallback-for-value-type
Sep 18, 2025
Merged

feat: add fallback support for value metric type#1606
zroubalik merged 1 commit intokedacore:mainfrom
y-rabie:support-fallback-for-value-type

Conversation

@y-rabie
Copy link
Contributor

@y-rabie y-rabie commented Aug 7, 2025

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Docs for: kedacore/keda#6655

@y-rabie y-rabie requested a review from a team as a code owner August 7, 2025 15:43
@netlify
Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit ba3a9af
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/68c436663d6cd40008569759
😎 Deploy Preview https://deploy-preview-1606--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@y-rabie y-rabie force-pushed the support-fallback-for-value-type branch from ad5b5af to aa008c0 Compare August 29, 2025 11:33
@wozniakjan wozniakjan requested a review from Copilot September 12, 2025 14:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the KEDA documentation to reflect that fallback support now includes both Value and AverageValue metric types, expanding beyond the previous limitation to only AverageValue metrics.

  • Adds support documentation for Value metric type fallback with its specific formula
  • Updates the limitations section to remove the restriction on Value metric types
  • Clarifies the different calculation formulas used for each metric type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: y-rabie <youssef.rabie@procore.com>
@y-rabie y-rabie force-pushed the support-fallback-for-value-type branch from aa008c0 to ba3a9af Compare September 12, 2025 15:04
@wozniakjan wozniakjan mentioned this pull request Sep 12, 2025
22 tasks
@zroubalik zroubalik merged commit 3a436cc into kedacore:main Sep 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants