Skip to content

update RabbitMQ scaler docs with additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes#1601

Merged
zroubalik merged 9 commits intokedacore:mainfrom
mgs2:feat/rabbitmq-add-new-modes
Dec 11, 2025
Merged

update RabbitMQ scaler docs with additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes#1601
zroubalik merged 9 commits intokedacore:mainfrom
mgs2:feat/rabbitmq-add-new-modes

Conversation

@mgs2
Copy link
Contributor

@mgs2 mgs2 commented Jul 28, 2025 •
edited
Loading

Documentation about RabbitMQ scaler has been updated with information about additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes. Changes have been introduced for upcoming (2.18) version.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Code update: kedacore/keda#6933

@mgs2
update RabbitMQ scaler docs with additional DeliverGetRate and Publis…
211de1c 
…hedToDeliveredRatio modes

Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@mgs2 mgs2 requested a review from a team as a code owner July 28, 2025 15:12
@netlify
Copy link

netlify bot commented Jul 28, 2025 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 9bfeab2
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/68ff630db2503f0008b01bdd
😎 Deploy Preview https://deploy-preview-1601--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@mgs2 mgs2 mentioned this pull request Jul 28, 2025
Merged
7 tasks
zroubalik
zroubalik reviewed Aug 26, 2025
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please omit the 2.17 version, this change will be present on >= 2.18 if merged

zroubalik
zroubalik reviewed Aug 26, 2025
View reviewed changes
@mgs2 mgs2 mentioned this pull request Aug 28, 2025
Merged
2 tasks
mgs2 added 2 commits September 9, 2025 20:19
@mgs2
publish information about new RabbitMQ scaler's trigger modes in 2.18…
37bf240 
… version

Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@mgs2
Merge branch 'main' into feat/rabbitmq-add-new-modes
ad2580e 
Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@mgs2
Copy link
Contributor Author

mgs2 commented Sep 9, 2025

Please omit the 2.17 version, this change will be present on >= 2.18 if merged

Done.

mgs2 added 2 commits September 9, 2025 23:10
@mgs2
typo
0773588 
Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@mgs2
Merge branch 'feat/rabbitmq-add-new-modes' of github.com:mgs2/keda-do…
9960cb7 
…cs into feat/rabbitmq-add-new-modes
@mgs2 mgs2 changed the title update RabbitMQ scaler docs with additional DeliverGetRate and PublishedToDeliveredRatio modes update RabbitMQ scaler docs with additional DeliverGetRate, PublishedToDeliveredRatio and ExpectedQueueConsumptionTime trigger modes Sep 9, 2025
@mgs2 mgs2 mentioned this pull request Oct 11, 2025
Closed
@mgs2
Copy link
Contributor Author

mgs2 commented Oct 11, 2025 •
edited
Loading

Related to PR kedacore/keda#6933 - code for new RabbitMQ scaler modes itself has been merged and shipped with 2.18 release, but docs retain content from 2.17.

Any chance to review this PR (+ request an update if necessary) and merge it, to keep RabbitMQ scaler docs up to date?

@mgs2 mgs2 requested a review from zroubalik October 11, 2025 20:40
@mgs2
update ExpectedQueueConsumptionTime notice on using longer pollingInt…
0352aa6 
…erval

Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@keda-automation keda-automation requested a review from a team October 13, 2025 09:57
@mgs2
actually, while using ExpectedQueueConsumptionTime pollingInterval *m…
0e8a758 
…ust* be set to 1 second

Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 26, 2025

Sorry because I missed this. The feature is already merged as part of v2.18, could you rebase this PR and update also the file in v2.19? (the change has to be in both files)

mgs2 added 2 commits October 27, 2025 13:14
@mgs2
Merge branch 'main' of github.com:mgs2/keda-docs into feat/rabbitmq-a…
d2af960 
…dd-new-modes
@mgs2
publish information about new RabbitMQ scaler's trigger modes in 2.19…
9bfeab2 
… version

Signed-off-by: Wojciech Moczulski <wojciech.moczulski@stormlabs.eu>
@mgs2
Copy link
Contributor Author

mgs2 commented Oct 27, 2025

Sorry because I missed this. The feature is already merged as part of v2.18, could you rebase this PR and update also the file in v2.19? (the change has to be in both files)

Done. Please, take a look. Any feedback on the content itself is more than welcome!

@zroubalik zroubalik merged commit 36fc5c8 into kedacore:main Dec 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgs2 @JorTurFer @zroubalik