Skip to content

feat: nsq scaler docs#1485

Merged
JorTurFer merged 6 commits intokedacore:mainfrom
Ulminator:nsq_scaler_docs
Nov 23, 2024
Merged

feat: nsq scaler docs#1485
JorTurFer merged 6 commits intokedacore:mainfrom
Ulminator:nsq_scaler_docs

Conversation

@Ulminator
Copy link
Contributor

@Ulminator Ulminator commented Oct 14, 2024 •
edited
Loading

Added nsq scaler documentation for v2.16 release.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to:

@Ulminator Ulminator requested a review from a team as a code owner October 14, 2024 21:09
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 763f2d8
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/673694e3a834e4000852ee46
😎 Deploy Preview https://deploy-preview-1485--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 14, 2024
Merged
Merged
@Ulminator Ulminator force-pushed the nsq_scaler_docs branch 4 times, most recently from bdefcc5 to 9bfd393 Compare October 14, 2024 21:46
@Ulminator
feat: nsq scaler docs
0b87ae3 
Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com>
@Ulminator
fix: add useHttps/unsafeSsl to nsq scaler docs
ce3f01c 
Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com>
JorTurFer
JorTurFer approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @zroubalik @wozniakjan PTAL

zroubalik
zroubalik reviewed Nov 5, 2024
View reviewed changes
@Ulminator
Merge branch 'main' into nsq_scaler_docs
67919ed
@Ulminator
fix: change idleReplicaCount -> minReplicaCount
d7b389d 
Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com>
@Ulminator Ulminator requested a review from zroubalik November 7, 2024 07:28
@or-shachar or-shachar mentioned this pull request Nov 11, 2024
Closed
6 tasks
@Ulminator
Merge branch 'main' into nsq_scaler_docs
0493256
@Ulminator
fix: move nsq docs from 2.16 to 2.17
763f2d8 
Signed-off-by: Matt Ulmer <25484774+Ulminator@users.noreply.github.com>
JorTurFer
JorTurFer approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer JorTurFer merged commit b423c03 into kedacore:main Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ulminator @zroubalik @JorTurFer