Skip to content

Update for Selenium Grid scaler#1468

Merged
JorTurFer merged 7 commits intokedacore:mainfrom
NDViet:main
Nov 3, 2024
Merged

Update for Selenium Grid scaler#1468
JorTurFer merged 7 commits intokedacore:mainfrom
NDViet:main

Conversation

@VietND96
Copy link
Contributor

Provide a description of what has been changed

An update for kedacore/keda#6169 will come in the upcoming release v2.16.
@SeleniumHQ involve as long term maintainer for the scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

@VietND96 VietND96 requested a review from a team as a code owner September 17, 2024 11:38
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 7ebfabb
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6727b843cc5d490008291e18
😎 Deploy Preview https://deploy-preview-1468--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VietND96 VietND96 changed the title Update for Selenium Grid scaler in release 2.16 Update for Selenium Grid scaler Sep 23, 2024
@VietND96
Copy link
Contributor Author

Updated this to be aligned with the decision in core changes.

@SeleniumHQ involve as maintainer

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️
@zroubalik PTAL

@VietND96 VietND96 requested a review from zroubalik October 22, 2024 20:00
VietND96 and others added 4 commits November 3, 2024 17:55
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@JorTurFer
Copy link
Member

Thanks a lot for your help and patience 🙇

@JorTurFer JorTurFer merged commit 5f6f155 into kedacore:main Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants