Hello!

A Pull Request has a template layout. Could you keep this on? This helps with providing a correct description and links.

Why is the addition of get_helm necessary?
Can you also solve the issue from the Static Check?

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,

As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.

I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.

The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,

As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.

I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.

The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

The get_helm script is not strictly necessary. I added it while updating the code because my GitHub Actions workflow was failing , will Delete this file

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,

As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.

I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.

The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

For the .gitignore file, I used a Python environment to resolve issues related to the pre-commit run --all-files command. I want to update the version, so I’m modifying this file

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,

As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.

I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.

The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

I used the latest Go version 1.24.1. After changing StrimziVersion = "0.47.0", I ran the go mod tidy command, which automatically updated the dependencies

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,
As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.
I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.
The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

For the .gitignore file, I used a Python environment to resolve issues related to the pre-commit run --all-files command. I want to update the version, so I’m modifying this file

If this is just for a private environment, please don’t upload it to the repository.

environment

I will changed

Hi @rickbrouwer , could you please take a moment to review this PR at your convenience? I would greatly appreciate your feedback.

Hi @adity1raut ,
As soon as you create a merge request, you'll see a merge request template. This template provides information so you can provide a clear description of the issue you're solving. It would be helpful if you could leave it intact and use it, as it helps us with the review. It looks like you've completely removed this.
I also see that you've made some changes to go.mod and go.sum. You've also added something to .gitignore that isn't necessary for this change.
The comment in the previous review hasn't been answered yet: "Why is the addition of get_helm necessary?"

I used the latest Go version 1.24.1. After changing StrimziVersion = "0.47.0", I ran the go mod tidy command, which automatically updated the dependencies

That is not necessary for now and out of scope of this PR.

That is not necessary for now and out of scope of this PR.

i chaned it

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

yes, you can delete it

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

yes, you can delete it

Sir, if there are any other changes you'd like me to make, please let me know

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

yes, you can delete it

Sir, if there are any other changes you'd like me to make, please let me know

Please also undo the dependency updates (go.mod en go.sum)

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

yes, you can delete it

Sir, if there are any other changes you'd like me to make, please let me know

Please also undo the dependency updates (go.mod en go.sum)

This dependency is necessary for this version

et_helm

Sir, get-helm is not necessary. If you don't want it, I can delete it

yes, you can delete it

Sir, if there are any other changes you'd like me to make, please let me know

Please also undo the dependency updates (go.mod en go.sum)

This dependency is necessary for this version

Can you explain me for better understanding.
If you run a go mod tidy against the current main branch without your update, will these dependency updates be included as well?

your

I am check once again

@rickbrouwer Could you please check this PR and share your review?

/run-e2e cron
Update: You can check the progress here

Hey @SpiritZhou , could you please review my PR

/run-e2e kafka
Update: You can check the progress here

I think that this PR is already covered by this other one that fixes some flaky tests too and updates the e2e tests to use the new CRDs.
I'd close this one in favor of the other one, WDYT?

Because of merging #6929, I will close this PR.
Thanks for the effort @adity1raut !