Add refactoring for datadog scaler#6552
Merged
zroubalik merged 3 commits intokedacore:mainfrom Apr 24, 2025
Merged
Conversation
58 tasks
dttung2905
commented
Feb 20, 2025
d59eb1a to
8f6280b
Compare
8f6280b to
dc86a22
Compare
Contributor
Author
|
/run-e2e datadog |
wozniakjan
reviewed
Apr 7, 2025
Member
wozniakjan
left a comment
There was a problem hiding this comment.
the refactor looks pretty good but probably some small regression has been added because it seems that e2e tests are failing now
helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - datadog-dca-test-deployment, Current - ***, Target - 0
datadog_dca_test.go:***58:
Error Trace: /__w/keda/keda/tests/sequential/datadog_dca/datadog_dca_test.go:***58
Error: Should be true
Test: TestDatadogScalerDCA
Messages: replica count should be 0 after *** minutes
datadog_dca_test.go:***68: --- testing activation ---
helper.go:54***: Applying template: lightLoadTemplate
helper.go:494: Waiting for some time to ensure deployment replica count doesn't change from 0
helper.go:50***: Deployment - datadog-dca-test-deployment, Current - ***
helper.go:504:
Error Trace: /__w/keda/keda/tests/helper/helper.go:504
/__w/keda/keda/tests/sequential/datadog_dca/datadog_dca_test.go:***7***
/__w/keda/keda/tests/sequential/datadog_dca/datadog_dca_test.go:***6***
Error: datadog-dca-test-deployment replica count has changed from 0 to ***
Test: TestDatadogScalerDCA
datadog_dca_test.go:***75: --- testing scale out ---
...
Failed tests:
Execution of tests/sequential/datadog_dca/datadog_dca_test.go, has failed after "two" attempts
make: *** [Makefile:***09: e***e-test] Error ***
0f8d4f6 to
7e6759e
Compare
Contributor
Author
|
/run-e2e datadog |
wozniakjan
approved these changes
Apr 9, 2025
Member
wozniakjan
left a comment
There was a problem hiding this comment.
looking great! just a minor formatting nits
also to pass the github checks after release, can you please rebase the PR on the latest main?
292a99c to
b0f4361
Compare
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
5b69695 to
1809288
Compare
Contributor
Author
|
/run-e2e datadog Update: You can check the progress here |
Contributor
Author
|
/run-e2e datadog |
Member
|
/run-e2e datadog |
zroubalik
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring the datadog scaler. It a little bit more complicated than I have imagined. There are a few TODO that I will resolve before marking this PR ready
Checklist
Relates to #5797