fix: Selenium Grid scaler logic on platformName is set empty or any#6477
Merged
JorTurFer merged 3 commits intokedacore:mainfrom Jan 17, 2025
Merged
fix: Selenium Grid scaler logic on platformName is set empty or any#6477JorTurFer merged 3 commits intokedacore:mainfrom
any#6477JorTurFer merged 3 commits intokedacore:mainfrom
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
This was referenced Jan 12, 2025
Member
|
/run-e2e selenium |
JorTurFer
approved these changes
Jan 17, 2025
wozniakjan
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Node stereotype set
"platformName": ""(empty), node started up and registered to Hub with converting to"platformName": "windows". Similarly, the same behavior in session capabilities. This unexpected behavior impacts the scaler in counting the pending and ongoing sessions.This issue is fixed in Grid core SeleniumHQ/selenium#15036 (
platformNameis empty should be considered as enum ANY instead of WINDOWS). Available from 4.28.0 onwards.The incoming request with setting capability
"platformName": "any"or not set. It will be assigned to any Node with the stereotypeplatformName: anyor not set.So, updating the scaler condition to be aligned with the same behavior.
Checklist
Fixes #
Relates to #