Remove Prometheus metric deprecations by rickbrouwer · Pull Request #6339 · kedacore/keda

rickbrouwer · 2024-11-17T19:09:14Z

Remove Prometheus metric deprecations

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Docs: kedacore/keda-docs#1501
Related: #5687

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

JorTurFer · 2024-11-23T22:15:34Z

/run-e2e sequential
Update: You can check the progress here

JorTurFer

Thanks for the cleanup!

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

wozniakjan

~~seems like the prometheus_metrics_test is now failing~~

never mind, I missed there has been a push with a fix, my bad

e2e test failure log

tests/sequential/prometheus_metrics/prometheus_metrics_test.go has failed after "two" attempts 
attempt number "one"
=== RUN   TestPrometheusMetrics
    prometheus_metrics_test.go:4***9: --- setting up ---
    helper.go:***47: deleting namespace prometheus-metrics-test-ns
    helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
    helper.go:***4: Creating namespace - prometheus-metrics-test-ns
    helper.go:54***: Applying template: deploymentTemplate
    helper.go:54***: Applying template: monitoredDeploymentTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    helper.go:54***: Applying template: scaledJobTemplate
    helper.go:54***: Applying template: clientTemplate
    helper.go:54***: Applying template: authenticatioNTemplate
    helper.go:54***: Applying template: cloudEventHTTPReceiverTemplate
    helper.go:54***: Applying template: cloudEventHTTPServiceTemplate
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    helper.go:4***7: Waiting for deployment replicas to hit target. Deployment - prometheus-metrics-test-deployment, Current  - ***, Target - ***
    prometheus_metrics_test.go:50***: --- testing scaler metric value ---
    prometheus_metrics_test.go:784: --- testing scaler metric latency ---
    prometheus_metrics_test.go:789: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:789
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:44***
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_scaler_metrics_latency not available
    prometheus_metrics_test.go:89***: --- testing scaler active metric ---
    prometheus_metrics_test.go:5***7: --- testing scaled object errors ---
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:54***: Applying template: wrongScaledObjectTemplate
    prometheus_metrics_test.go:5***8: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:5***8
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:444
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_scaled_object_errors not available
    helper.go:6***0: Deleting template: wrongScaledObjectTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:569: --- testing scaled job errors ---
    helper.go:6***0: Deleting template: scaledJobTemplate
    helper.go:54***: Applying template: wrongScaledJobTemplate
    prometheus_metrics_test.go:580: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:580
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:445
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_scaled_job_errors not available
    prometheus_metrics_test.go:606: metric not available
    helper.go:6***0: Deleting template: wrongScaledJobTemplate
    helper.go:54***: Applying template: scaledJobTemplate
    prometheus_metrics_test.go:6***5: --- testing scaler errors ---
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:54***: Applying template: wrongScaledObjectTemplate
    helper.go:6***0: Deleting template: scaledJobTemplate
    helper.go:54***: Applying template: wrongScaledJobTemplate
    prometheus_metrics_test.go:6***7: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:6***7
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:446
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_scaler_errors not available
    helper.go:6***0: Deleting template: wrongScaledJobTemplate
    helper.go:54***: Applying template: scaledJobTemplate
    helper.go:6***0: Deleting template: wrongScaledObjectTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:65***: --- testing scaler errors total ---
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:54***: Applying template: wrongScaledObjectTemplate
    prometheus_metrics_test.go:660: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:660
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:447
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_scaler_errors_total not available
    helper.go:6***0: Deleting template: wrongScaledObjectTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:9***7: --- testing operator metrics ---
    prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
    prometheus_metrics_test.go:***079: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:9***8
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_trigger_totals not available
    prometheus_metrics_test.go:***0: --- testing resource total metrics ---
    prometheus_metrics_test.go:***: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:9***8
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_resource_totals not available
    prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
    prometheus_metrics_test.go:***0***9: --- testing build info metric ---
    helper.go:54***: Applying template: cronScaledJobTemplate
    prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
    prometheus_metrics_test.go:***079: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:94***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_trigger_totals not available
    prometheus_metrics_test.go:***0: --- testing resource total metrics ---
    prometheus_metrics_test.go:***: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:94***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_resource_totals not available
    prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
    prometheus_metrics_test.go:***0***9: --- testing build info metric ---
    helper.go:6***0: Deleting template: cronScaledJobTemplate
    prometheus_metrics_test.go:***076: --- testing trigger total metrics ---
    prometheus_metrics_test.go:***079: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***079
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:944
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_trigger_totals not available
    prometheus_metrics_test.go:***0: --- testing resource total metrics ---
    prometheus_metrics_test.go:***: 
        	Error Trace:	/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:***0***
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:944
        	            				/__w/keda/keda/tests/sequential/prometheus_metrics/prometheus_metrics_test.go:448
        	Error:      	Should be true
        	Test:       	TestPrometheusMetrics
        	Messages:   	keda_resource_totals not available
    prometheus_metrics_test.go:***84: --- testing grpc server metrics ---
    prometheus_metrics_test.go:***0***9: --- testing build info metric ---
    prometheus_metrics_test.go:***405: --- testing metric server metrics ---
    prometheus_metrics_test.go:***8***: --- testing grpc client metrics ---
    prometheus_metrics_test.go:948: --- testing webhook metrics ---
    helper.go:56***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:***6***: --- testing webhook metrics ---
    prometheus_metrics_test.go:8***6: --- testing scalable objects latency ---
    prometheus_metrics_test.go:858: scaledobject metric not available
    prometheus_metrics_test.go:9***7: --- testing scaleobject pause metric ---
    helper.go:54***: Applying template: scaledObjectPausedTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:***440: --- testing cloudevent emitted ---
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:54***: Applying template: cloudEventSourceTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    prometheus_metrics_test.go:***469: --- testing cloudevent emitted error ---
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:6***0: Deleting template: cloudEventSourceTemplate
    helper.go:54***: Applying template: wrongCloudEventSourceTemplate
    helper.go:54***: Applying template: scaledObjectTemplate
    helper.go:6***0: Deleting template: wrongCloudEventSourceTemplate
    helper.go:54***: Applying template: cloudEventSourceTemplate
    helper.go:6***0: Deleting template: cloudEventHTTPServiceTemplate
    helper.go:6***0: Deleting template: cloudEventHTTPReceiverTemplate
    helper.go:6***0: Deleting template: authenticatioNTemplate
    helper.go:6***0: Deleting template: clientTemplate
    helper.go:6***0: Deleting template: scaledJobTemplate
    helper.go:6***0: Deleting template: scaledObjectTemplate
    helper.go:6***0: Deleting template: monitoredDeploymentTemplate
    helper.go:6***0: Deleting template: deploymentTemplate
    helper.go:***47: deleting namespace prometheus-metrics-test-ns
    helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
    helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
    helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
    helper.go:***0***: waiting for namespace prometheus-metrics-test-ns deletion
--- FAIL: TestPrometheusMetrics (***5***.57s)
FAIL
FAIL	command-line-arguments	***5***.6***6s
FAIL

wozniakjan · 2024-11-26T17:08:12Z

/run-e2e sequential
Update: You can check the progress here

wozniakjan · 2024-11-26T18:30:48Z

@rickbrouwer hmm, still looks like e2es may need some extra care

Execution of tests/sequential/prometheus_metrics/prometheus_metrics_test.go, has failed after "two" attempts

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer · 2024-11-27T11:39:58Z

@rickbrouwer hmm, still looks like e2es may need some extra care
Execution of tests/sequential/prometheus_metrics/prometheus_metrics_test.go, has failed after "two" attempts

I have made an adjustment to the test. Only now a good check is needed to see if I have not adjusted the test too much.

wozniakjan · 2024-11-27T12:12:24Z

/run-e2e sequential
Update: You can check the progress here

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

wozniakjan · 2025-01-13T16:53:39Z

/run-e2e sequential
Update: You can check the progress here

tests/sequential/prometheus_metrics/prometheus_metrics_test.go

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

JorTurFer · 2025-01-17T12:49:13Z

/run-e2e sequential
Update: You can check the progress here

rickbrouwer requested a review from a team as a code owner November 17, 2024 19:09

rickbrouwer mentioned this pull request Nov 17, 2024

Remove Prometheus metric deprecations kedacore/keda-docs#1501

Merged

1 task

Remove Prometheus metric deprecations

7ec52cf

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

rickbrouwer force-pushed the prometheus branch from 353e1fd to 7ec52cf Compare November 17, 2024 19:19

rickbrouwer marked this pull request as draft November 17, 2024 19:19

rickbrouwer marked this pull request as ready for review November 17, 2024 19:34

JorTurFer enabled auto-merge (squash) November 23, 2024 22:15

JorTurFer approved these changes Nov 23, 2024

View reviewed changes

Fix test accordingly pr 5174

3a7c955

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

auto-merge was automatically disabled November 26, 2024 12:58
Head branch was pushed to by a user without write access

wozniakjan reviewed Nov 26, 2024

View reviewed changes

Fix test

ed7379c

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

rickbrouwer force-pushed the prometheus branch from 812e8ce to ed7379c Compare November 26, 2024 20:05

Merge branch 'main' into prometheus

745a5d2

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>

wozniakjan approved these changes Jan 13, 2025

View reviewed changes

wozniakjan reviewed Jan 13, 2025

View reviewed changes

tests/sequential/prometheus_metrics/prometheus_metrics_test.go Show resolved Hide resolved

Update test

91ee844

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>

JorTurFer enabled auto-merge (squash) January 17, 2025 12:50

JorTurFer merged commit 5e7af9e into kedacore:main Jan 17, 2025

rickbrouwer deleted the prometheus branch January 17, 2025 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Prometheus metric deprecations#6339

Remove Prometheus metric deprecations#6339
JorTurFer merged 5 commits intokedacore:mainfrom
rickbrouwer:prometheus

rickbrouwer commented Nov 17, 2024

Uh oh!

JorTurFer commented Nov 23, 2024 •

edited by github-actions bot

Loading

Uh oh!

JorTurFer left a comment

Uh oh!

wozniakjan left a comment •

edited

Loading

Uh oh!

wozniakjan commented Nov 26, 2024 •

edited by github-actions bot

Loading

Uh oh!

wozniakjan commented Nov 26, 2024

Uh oh!

rickbrouwer commented Nov 27, 2024

Uh oh!

wozniakjan commented Nov 27, 2024 •

edited by github-actions bot

Loading

Uh oh!

wozniakjan commented Jan 13, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

JorTurFer commented Jan 17, 2025 •

edited by github-actions bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rickbrouwer commented Nov 17, 2024

Checklist

Uh oh!

JorTurFer commented Nov 23, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

wozniakjan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wozniakjan commented Nov 26, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Nov 26, 2024

Uh oh!

rickbrouwer commented Nov 27, 2024

Uh oh!

wozniakjan commented Nov 27, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Jan 13, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Jan 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JorTurFer commented Nov 23, 2024 •

edited by github-actions bot

Loading

wozniakjan left a comment •

edited

Loading

wozniakjan commented Nov 26, 2024 •

edited by github-actions bot

Loading

wozniakjan commented Nov 27, 2024 •

edited by github-actions bot

Loading

wozniakjan commented Jan 13, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Jan 17, 2025 •

edited by github-actions bot

Loading