Closed
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
628a9d3 to
4a32338
Compare
2 tasks
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
Signed-off-by: ross-p-smith <rosmith@microsoft.com>
zroubalik
reviewed
Jun 22, 2023
Member
zroubalik
left a comment
There was a problem hiding this comment.
@ross-p-smith thanks for the contribution! I haven't done the full review yet, though there is one main thing missing - e2e tests. It's a hard requirement for us to accept a new scaler. Thanks!
Author
|
Moving to draft whilst I schedule writing the e2e tests - @ScruffyFurn |
7 tasks
Member
|
@ross-p-smith based on #4863 (comment), can we close this PR then? |
Member
|
Closing based on #4863 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a scaler for https://temporal.io/
Checklist
Fixes #4724
Relates to Docs 1163