Skip to content

Don't call Azure queue GetProperties API unnecessarily#2613

Merged
JorTurFer merged 5 commits intokedacore:mainfrom
RamCohen:azure-queue
Feb 14, 2022
Merged

Don't call Azure queue GetProperties API unnecessarily#2613
JorTurFer merged 5 commits intokedacore:mainfrom
RamCohen:azure-queue

Conversation

@RamCohen
Copy link
Contributor

@RamCohen RamCohen commented Feb 9, 2022

This PR reorders the logic of getting an Azure queue size in a way
that skips the call to get the queue properties (for getting the
ApproximateMessagesCount) if the queue has less than 32 messages.

Signed-off-by: Ram Cohen ram.cohen@gmail.com

This PR reorders the logic of getting an Azure queue size in a way
that skips the call to get the queue properties (for getting the
ApproximateMessagesCount) if the queue has less than 32 messages.

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@RamCohen RamCohen requested a review from a team as a code owner February 9, 2022 13:36
@JorTurFer
Copy link
Member

JorTurFer commented Feb 9, 2022

/run-e2e azure-queue*
Update: You can check the progres here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!,
Let's wait till e2e tests finish
Thanks for your contribution ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Feb 9, 2022

/run-e2eazure-queue.test*
Update: You can check the progres here

JorTurFer
JorTurFer previously approved these changes Feb 9, 2022
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We will keep this PR open till we have released v2.6.1 because we'd like to release in it only bugfixes.
When we have release it, I'll ping you again for updating the changelog.

Thanks for your contribution ❤️

@JorTurFer JorTurFer dismissed their stale review February 9, 2022 16:16

wrong click

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
We will keep this PR open till we have released v2.6.1 because we'd like to release in it only bugfixes.
When we have release it, I'll ping you again for updating the changelog.

Thanks for your contribution ❤️

@JorTurFer JorTurFer self-assigned this Feb 9, 2022
@JorTurFer JorTurFer added this to the v2.7.0 milestone Feb 9, 2022
@JorTurFer
Copy link
Member

hey @RamCohen
Could you update the changelog.md?

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@JorTurFer
Copy link
Member

There is a conflict in the changelog.
Could you solve it? (I'll merge this once is ready)

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RamCohen ,
Only small nits 😄

Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ❤️ ❤️

@JorTurFer JorTurFer merged commit 85dd397 into kedacore:main Feb 14, 2022
@RamCohen RamCohen deleted the azure-queue branch February 17, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants