Skip to content
This repository was archived by the owner on May 3, 2021. It is now read-only.
This repository was archived by the owner on May 3, 2021. It is now read-only.

df_setImageWithResource: with nil url crashes the application #35

@Quarezz

Description

@Quarezz

DFImageManagerKit+UI.h


[self.imageViewIcon df_setImageWithResource:[NSURL URLWithString:data.imageUrl]];


Crashes here:

- (DFImageTask *)imageTaskForRequest:(DFImageRequest *)request completion:(DFImageRequestCompletion)completion {
    id<DFImageManaging> manager = DFManagerForRequest(request);
    if (!manager) {
        [NSException raise:NSInvalidArgumentException format:@"There are no managers that can handle the request %@", request];
    }
    return [manager imageTaskForRequest:request completion:completion];
}

Not really a bug, as I passed nil instead of NSURL, but still I think crashing is not the best choice.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions