lang edits (careful merging w/upstream comments)#4
Merged
kdenhartog merged 3 commits intokdenhartog:kdh/eip-6963-updatesfrom Jul 4, 2023
bumblefudge:master
Merged
lang edits (careful merging w/upstream comments)#4kdenhartog merged 3 commits intokdenhartog:kdh/eip-6963-updatesfrom bumblefudge:master
kdenhartog merged 3 commits intokdenhartog:kdh/eip-6963-updatesfrom
bumblefudge:master
Conversation
Author
|
|
|
The commit 892f913 (as a parent of b046d95) contains errors. |
Owner
|
I believe this just needs to be merged in for it to work: ethereum/eipw@3f4e025 The syntax shouldn't make a difference here as I already went through and updated the linking in eipw bot in the past because the alternative markdown linking wasn't catching some of these cases in the past. |
Author
|
it might be worth merging for the rephrasings and dealing with the link stuff later, since the other implementers are [re-]reading today, it seems... |
Author
|
(assuming they're good! feel free to just cherry pick changes and ignore the PR) |
Owner
|
Yeah I just merged them all in. For some reason GH failed the first time I tried, but a page reload fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lol not sure whether the github bot will allow my usage of
syntax, I thought that was standard markdown? maybe it's esoteric linux-dood markdown. i might need to work with the EIP editors on this next week, if so...