Skip to content

feat: allow --oidc-ca-file configuration#89

Merged
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom
aaronschweig:main
Sep 2, 2025
Merged

feat: allow --oidc-ca-file configuration#89
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom
aaronschweig:main

Conversation

@aaronschweig
Copy link
Copy Markdown
Contributor

@aaronschweig aaronschweig commented Sep 1, 2025 •
edited
Loading

Summary

There was still a TODO comment in the authentication section that was deferring the implementation of this flag. This PR adds that.

It is just a proposal - implementationwise pretty straight forward, but happy to change the API if wanted.

What Type of PR Is This?

/kind feature
/kind api-change

Related Issue(s)

Fixes #

Release Notes

Add the ability to configure a custom CA for the OIDC issuer as described in the `--oidc-ca-file` flag.

@aaronschweig
feat: allow --oidc-ca-file configuration
9ef5e0b 
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 1, 2025

Hi @aaronschweig. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 1, 2025
@embik
Copy link
Copy Markdown
Member

embik commented Sep 1, 2025

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2025
embik
embik requested changes Sep 1, 2025
View reviewed changes
xrstf
xrstf reviewed Sep 1, 2025
View reviewed changes
@kcp-ci-bot kcp-ci-bot added dco-signoff: no Indicates the PR's author has not signed the DCO. and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Sep 2, 2025
nexus49 and others added 2 commits September 2, 2025 09:03
@nexus49 @aaronschweig
fix: fix setting of volumes for authorization webhook
8a8228d 
Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
@aaronschweig
chore: add comment to newly introduced API and remove newline
97e19ba 
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. dco-signoff: no Indicates the PR's author has not signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Sep 2, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 2, 2025

@aaronschweig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary 97e19ba link false /test pull-kcp-operator-test-e2e-canary

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

embik
embik approved these changes Sep 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 2, 2025

LGTM label has been added.

DetailsGit tree hash: b6d2fbdfacf68bf38f356a74d64a93610604ec2a

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2025
@kcp-ci-bot kcp-ci-bot merged commit ab5c966 into kcp-dev:main Sep 2, 2025
10 of 11 checks passed
@aaronschweig aaronschweig mentioned this pull request Sep 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrstf xrstf xrstf left review comments

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aaronschweig @kcp-ci-bot @embik @xrstf @nexus49