Skip to content

fix: fix setting of volumes for authorization webhook configurations#88

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
nexus49:main
Sep 1, 2025
Merged

fix: fix setting of volumes for authorization webhook configurations#88
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
nexus49:main

Conversation

@nexus49
Copy link
Copy Markdown
Contributor

@nexus49 nexus49 commented Aug 31, 2025

Summary

What Type of PR Is This?

/kind bug

Related Issue(s)

Release Notes

Fixes an issue where volumes have not been properly set for authorization webhooks

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 31, 2025

Hi @nexus49. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2025
@nexus49
fix: fix setting of volumes for authorization webhook
b7da437 
Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Aug 31, 2025
embik
embik approved these changes Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 1, 2025

LGTM label has been added.

DetailsGit tree hash: a5b66c7c0aef2cf43d682d7059f585118dd26d7e

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
@embik
Copy link
Copy Markdown
Member

embik commented Sep 1, 2025

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Sep 1, 2025 •
edited
Loading

@nexus49: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-operator-test-e2e-canary b7da437 link false /test pull-kcp-operator-test-e2e-canary

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@embik
Copy link
Copy Markdown
Member

embik commented Sep 1, 2025

/retest

flake?

@kcp-ci-bot kcp-ci-bot merged commit ef879dc into kcp-dev:main Sep 1, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nexus49 @kcp-ci-bot @embik