Closed
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
This is to bootstrap the necessary RBAC on each shard to allow other controllers in the operator to perform their actions *even if they have to go through a front-proxy that drops system:masters*. On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
Author
|
/retest |
…ning On-behalf-of: @SAP christoph.mewes@sap.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We want to provision RBAC rules for kubeconfigs. For that the idea is to connect to the kubeconfig's target (shard, rootshard or front-proxy) and create the Kube objects that way. This allows the operator to profit from the front-proxy's shard resolving capabilities (so that a Kubeconfig that targets a front-proxy can ask to provision RBAC in any workspace).
However the front-proxy will remove the system:masters group from the authInfo, so when we rely on it, we could not connect through a front-proxy to a shard and still be authorized to do anything.
To solve this, this PR adds a new bootstrapping controller that will place a ClusterRole and ClusterRoleBinding on each shard's
system:admincluster. This gives anyone namedsystem:kcp-operatorpermissions to do what we need to do (atm this is nothing, but once the RBAC-for-kubeconfig stuff is implemented, we need to be allowed to create CR/CRBs in every possible workspace).A new condition on Shards and RootShards informs users about the status of the bootstrapping. This will be important for the kubeconfig controller, so it can defer provisioning RBAC if bootstrapping hasn't completed yet.
To gain access to perform this bootstrapping, a single new client cert is created, which is owned by the RootShard. Since all shards use the same ClientCA, they will all accept it.
What Type of PR Is This?
/kind feature
Release Notes