Summary

I am working on at least 2 new controllers and we have reached the point where too many controllers share the same package. So I moved every controller into its own sub directory.

But this made the tests explode, because they are written to assume global private variables and a single test suite. Instead of painfully refactoring them, I painfully refactored them, but into simple, shorter, regular Go tests. I also replaced the usage of envtest with ctrl-runtime's fake client.

Due to the missing envtest, Deployments will not progress and so will not have their status fields defaulted when using fake clients. This has unearthed that the status handling in the operator was broken, regardless of envtest or fakeclient. Not only did it assume that an error when getting the deployment status is not severe (it is, if that part errors there is no Available condition and the code further down in the switch statement panics), but it would also not apply the Deleting phase ever as long as a Deployment exists. So I reworked the status handling a bit and also made it compatible with static backends (like fakeclient or kcp).

I also replaced gomega with require, which we use in kcp already and more importantly, is nice to use without the need for a dot import. Dot import bad.

What Type of PR Is This?

/kind cleanup

Release Notes

Remove Ginkgo from unit tests, use fakeclient instead of envtest.