Skip to content

extend front-proxy server cert DNSNames with namespaced and cluster-global DNS names#83

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
xrstf:extend-fp-cert-names
Aug 27, 2025
Merged

extend front-proxy server cert DNSNames with namespaced and cluster-global DNS names#83
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
xrstf:extend-fp-cert-names

Conversation

@xrstf
Copy link
Copy Markdown
Contributor

@xrstf xrstf commented Aug 20, 2025

Summary

This extends the list of domains in the serving cert for the front-proxy from

  • $fpService
  • $rootShardExternalName

by

  • $fpService.$namespace
  • $fpService.$namespace.svc.cluster.local

What Type of PR Is This?

/kind feature

Release Notes

The serving cert for front-proxies now includes the namespaced (`serviceName.namespace`) fully-qualified (`serviceName.namespace.svc.cluster.local`) names of the front-proxy Service.

@xrstf
extend front-proxy server cert DNSNames with namespaced and cluster-g…
1f8f9f4 
…lobal DNS names

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2025
@xrstf xrstf requested a review from SimonTheLeg August 20, 2025 14:44
@SimonTheLeg
Copy link
Copy Markdown
Member

SimonTheLeg commented Aug 27, 2025

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 27, 2025

LGTM label has been added.

DetailsGit tree hash: d7851c775372ed589eadbd0bf51a03bdc2a712c9

@xrstf
Copy link
Copy Markdown
Contributor Author

xrstf commented Aug 27, 2025

/approve

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimonTheLeg, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2025
@kcp-ci-bot kcp-ci-bot merged commit 887d515 into kcp-dev:main Aug 27, 2025
10 checks passed
@xrstf xrstf deleted the extend-fp-cert-names branch September 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimonTheLeg SimonTheLeg Awaiting requested review from SimonTheLeg

Assignees

@SimonTheLeg SimonTheLeg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrstf @SimonTheLeg @kcp-ci-bot