Skip to content

Update CONTRIBUTING.md#184

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
KevinGimbel:patch-1
Apr 1, 2026
Merged

Update CONTRIBUTING.md#184
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
KevinGimbel:patch-1

Conversation

@KevinGimbel
Copy link
Copy Markdown
Contributor

@KevinGimbel KevinGimbel commented Mar 26, 2026

Fix link to kcp Contributing Guide

Summary

What Type of PR Is This?

/kind documentation

Related Issue(s)

/

Release Notes

fix: Correct link to kcp Contributing Documentation

@kcp-ci-bot kcp-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Mar 26, 2026

Hi @KevinGimbel. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2026
ntnn
ntnn reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ntnn ntnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve
/lgtm

Thanks!

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Mar 26, 2026

LGTM label has been added.

DetailsGit tree hash: bbe04baa427457dd624f93607e5d1bfe2c7a8c24

@KevinGimbel
Update CONTRIBUTING.md
a428e03 
fix link to kcp Contributing Guide

Signed-off-by: Kevin Gimbel <kevin@gimbel.dev>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Mar 26, 2026
@KevinGimbel
Copy link
Copy Markdown
Contributor Author

KevinGimbel commented Mar 26, 2026

Force pushed to signoff the commit ✨

@ntnn ntnn added this to tbd Mar 26, 2026
@github-project-automation github-project-automation bot moved this to Backlog in tbd Mar 26, 2026
@ntnn
Copy link
Copy Markdown
Member

ntnn commented Mar 27, 2026

Awesome, thank you!
/assign @xrstf @mjudeikis
Please lgtm

@ntnn ntnn moved this from Backlog to Reviewing in tbd Mar 28, 2026
xrstf
xrstf approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks!

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@kcp-ci-bot kcp-ci-bot merged commit 96ca110 into kcp-dev:main Apr 1, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Reviewing to Done in tbd Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntnn ntnn ntnn left review comments

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

@mjudeikis mjudeikis

@ntnn ntnn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KevinGimbel @kcp-ci-bot @ntnn @xrstf @mjudeikis