Add revision labels to PodTemplates in order to automatically rotate Deployments#161
Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
Author
|
/kind feature |
…Deployments On-behalf-of: @SAP christoph.mewes@sap.com
1d7fe00 to
a8f67a2
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: b8dd8b6f7b62e7c5316728f3324914eeebaf2377 |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds "revision labels" to the PodTemplates in the Deployments managed by the kcp-operator: One label for each mounted Secret/ConfigMap, containing those objects' resource version.
The usecase is to automatically rotate Deployments whenever Secrets change, which happens every time a Certificate is renewed or changed (like a new organization being added).
The new middleware will return an error if a mounted object does not exist yet, so while a new Shard or RootShard or FrontProxy is being rolled out, a lot of errors would happen until all Certificates have been issued by cert-manager. To avoid spamming the logs, the operator swallows these errors and relies on it watching the Secrets to reconcile again later. The other alternative would be to skip labels for non-existent mounted Secrets, but this will just lead to lots of pointless pods being created (pointless because even though the operator ignores the missing Secrets, Kubernetes cannot and so the Pods would all be in ContainerCreating). This feels worse than holding off the Deployment creation.
What Type of PR Is This?
/kind feature
Release Notes