fix local-cluster-admin kubeconfigs for shards not pointing to the shards#156
Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom Feb 19, 2026
Merged
Conversation
…ards On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
|
LGTM label has been added. DetailsGit tree hash: 895026d21f99e81531bc16074d191cc9ddf3120d |
Contributor
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I assume this was a simple copy-paste mistake I made when implementing shard support. At least I cannot imagine why all shards would be configured with a lca-kubeconfig that points to the root shard. @mjudeikis hinted that it's already curious that each shard gets a
--root-shard-kubeconfig-file, since shard->rootShard communication should happen via front-proxy, no? (I hope I represented that thought correctly). So why would the lca-kubeconfig also point to the root shard?What Type of PR Is This?
/kind bug
Release Notes