Skip to content

extend sample manifests to reflect external access#138

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mandelsoft:samples
Jan 22, 2026
Merged

extend sample manifests to reflect external access#138
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mandelsoft:samples

Conversation

@mandelsoft
Copy link
Copy Markdown
Contributor

@mandelsoft mandelsoft commented Jan 22, 2026

Summary

The sample manifests under config/samples describe an external hostname in the rootshard manifest.
But the rest of the manifest and the matching frontproxy manifest do not completely match this feature.
Missing are:

  • in the rootshard
    • shardBaseURL
    • additional server certificate SAN
    • service type in serviceTemplate
  • in the frontproxy
    • service type in serviceTemplate

What Type of PR Is This?

/kind documentation

Related Issue(s)

Fixes #

Release Notes

NONE

@mandelsoft
extend sample manifests
03d4120 
Signed-off-by: Uwe Krueger <uwe.krueger@goldmail.de>
@kcp-ci-bot kcp-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 22, 2026

Hi @mandelsoft. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor

mjudeikis commented Jan 22, 2026

/lgtm
/approve

Thanks for this!

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 22, 2026

LGTM label has been added.

DetailsGit tree hash: c4c28345941b5cf5a52d08cbd1b1d1c885058723

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
@kcp-ci-bot kcp-ci-bot merged commit f04d496 into kcp-dev:main Jan 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mandelsoft @kcp-ci-bot @mjudeikis