Skip to content

Remove obsolete Makefile targets from target dependency lists#137

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mandelsoft:main
Jan 23, 2026
Merged

Remove obsolete Makefile targets from target dependency lists#137
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mandelsoft:main

Conversation

@mandelsoft
Copy link
Copy Markdown
Contributor

@mandelsoft mandelsoft commented Jan 21, 2026

Summary

After previous Makefile refactorings several targets still use dependencies to removed targets.

What Type of PR Is This?

/kind bug
/kind regression

Related Issue(s)

Fixes #

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. kind/regression Categorizes issue or PR as related to a regression from a prior release. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 21, 2026

Hi @mandelsoft. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2026
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jan 21, 2026
xrstf
xrstf reviewed Jan 22, 2026
View reviewed changes
Makefile Outdated
@@ -1,4 +1,4 @@
# Copyright 2025 The KCP Authors.
# Copyright 2026 The KCP Authors.
Copy link
Copy Markdown
Contributor

@xrstf xrstf Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to constantly change the copyrights in all of your files.

Copy link
Copy Markdown
Contributor Author

@mandelsoft mandelsoft Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to 2025

@kcp-ci-bot kcp-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2026
@mandelsoft
fix Makefile
afe97ad 
Signed-off-by: Uwe Krueger <uwe.krueger@goldmail.de>
xrstf
xrstf approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 23, 2026

LGTM label has been added.

DetailsGit tree hash: c29c8f58b71f9d10075b8611ffc631d72fc8da09

@xrstf
Copy link
Copy Markdown
Contributor

xrstf commented Jan 23, 2026

/approve

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@kcp-ci-bot kcp-ci-bot merged commit 275f021 into kcp-dev:main Jan 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mandelsoft @kcp-ci-bot @xrstf