Skip to content

Clean old rbac#136

Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mjudeikis:cleanup.rbac
Feb 3, 2026
Merged

Clean old rbac#136
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom
mjudeikis:cleanup.rbac

Conversation

@mjudeikis
Copy link
Copy Markdown
Contributor

@mjudeikis mjudeikis commented Jan 20, 2026

Summary

I dont think we use these anymore?

What Type of PR Is This?

/kind cleanup

Related Issue(s)

Fixes #

Release Notes

Removed end user ClusterRole manifests

@kcp-ci-bot kcp-ci-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2026
@mjudeikis
Copy link
Copy Markdown
Contributor Author

/test all

@ntnn
Copy link
Copy Markdown
Member

ntnn commented Feb 3, 2026

Weren't these so users can use pre-made roles to edit operator resources?

@mjudeikis
Copy link
Copy Markdown
Contributor Author

I think this is a leftover from the old generation pattern. We have role already. these are not updated anymore

@mjudeikis
Copy link
Copy Markdown
Contributor Author

@ntnn
Copy link
Copy Markdown
Member

ntnn commented Feb 3, 2026

That is the role for the operator service account; I think those were meant for end users. But tbh it doesn't really matter, end users can just make their own roles with access to the operator APIs if they need it.

@ntnn
Copy link
Copy Markdown
Member

ntnn commented Feb 3, 2026

Just to be safe add a release note. Don't think anyone used those manifests but in case someone did they'll have an easier time finding what happened to them.

@ntnn
Copy link
Copy Markdown
Member

ntnn commented Feb 3, 2026

/release-note-edit

Removed end user ClusterRole manifests

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 3, 2026
@ntnn
Copy link
Copy Markdown
Member

ntnn commented Feb 3, 2026

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 8b8f8c7985f29abe3e02d0a89c3129092a3231b1

@xrstf
Copy link
Copy Markdown
Contributor

xrstf commented Feb 3, 2026

I think this was a concept mostly carried over from Kubermatic side, so yeah, I can see us removing it.

/approve

@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ntnn, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2026
@kcp-ci-bot kcp-ci-bot merged commit 1b1cdad into kcp-dev:main Feb 3, 2026
6 checks passed
@xrstf xrstf mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants