Introduce standalone SDK#60
Merged
Merged
Conversation
embik
requested changes
May 16, 2025
embik
left a comment
Member
There was a problem hiding this comment.
Can we maybe add a quick markdown doc somewhere for the release process so that people tagging this repo are aware they need to tag both sdk and main module?
Contributor
|
LGTM label has been added. DetailsGit tree hash: 63fe19c3155c710bab356f1208035a5fa6a8b929 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is exactly what kcp is also doing, declaring the SDK to be a standalone module to make it easier to import. I updated the codegen logic to "the best" kcp on kube 1.31 has to offer. Once kcp 0.28 is out, we can switch to kube_codegen.sh and cluster_codegen.sh and make it all silky smooth.
What Type of PR Is This?
/kind feature
Release Notes