Skip to content

ci: fix mkdocs requirements for gh-pages#55

Merged
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
mirzakopic:ci/fixghpagesworkflow
Apr 25, 2025
Merged

ci: fix mkdocs requirements for gh-pages#55
kcp-ci-bot merged 1 commit into
kcp-dev:mainfrom
mirzakopic:ci/fixghpagesworkflow

Conversation

@mirzakopic

@mirzakopic mirzakopic commented Apr 25, 2025

Copy link
Copy Markdown

Summary

Fixing the requirements needed for mkdocs and gh-pages publishing.

See below
image

What Type of PR Is This?

/kind documentation

Related Issue(s)

#26

Fixes #

Release Notes

NONE

@mirzakopic
ci: fix mkdocs requirements for gh-pages
936e3a4 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@kcp-ci-bot kcp-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2025
@kcp-ci-bot

kcp-ci-bot commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

Hi @mirzakopic. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2025
@embik

embik commented Apr 25, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2025
embik
embik approved these changes Apr 25, 2025
View reviewed changes

@embik embik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
@kcp-ci-bot

kcp-ci-bot commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 4a4668fe931f29518c281a20dfe12f24f4a44d7c

@kcp-ci-bot

kcp-ci-bot commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@kcp-ci-bot kcp-ci-bot merged commit d61383a into kcp-dev:main Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirzakopic @kcp-ci-bot @embik