Skip to content

feat: docs website for api-syncagent#53

Merged
kcp-ci-bot merged 6 commits into
kcp-dev:mainfrom
mirzakopic:feat/docs-pages
Apr 23, 2025
Merged

feat: docs website for api-syncagent#53
kcp-ci-bot merged 6 commits into
kcp-dev:mainfrom
mirzakopic:feat/docs-pages

Conversation

@mirzakopic

@mirzakopic mirzakopic commented Apr 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Summary

This is a PR for introducing the api-syncagent documentation as per #26

image

What Type of PR Is This?

/kind documentation

Related Issue(s)

#26

Release Notes

NONE

@kcp-ci-bot kcp-ci-bot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2025
@kcp-ci-bot

kcp-ci-bot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Hi @mirzakopic. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Apr 15, 2025
@mirzakopic
docs: add docs website for api-syncagent
141d188 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Apr 15, 2025
@embik

embik commented Apr 15, 2025

Copy link
Copy Markdown
Member

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2025
embik
embik requested changes Apr 15, 2025
View reviewed changes
Comment thread website/mkdocs.yml Outdated
Comment thread docs/publish-resources.md Outdated
@mirzakopic
docs: help page using mkdocs from docs dir
54b46b6 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@mirzakopic
docs: moved md files to content subdir in docs
cc349bc 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
@mirzakopic
docs: update gitignore
f61bcb2 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: no Indicates the PR's author has not signed the DCO. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 16, 2025
@mirzakopic
Merge branch 'main' into feat/docs-pages
8eb620d 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Apr 16, 2025
@embik

embik commented Apr 16, 2025

Copy link
Copy Markdown
Member

Looks like docs/mkdocs.yml also needs the license boilerplate header. That plus re-adding the release notes to the PR description and we should be good to go!

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2025
@mirzakopic
add license for mkdocs in docs
20d78a9 
Signed-off-by: Mirza Kopic <mirza.kopic@sap.com>
embik
embik approved these changes Apr 23, 2025
View reviewed changes

@embik embik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@kcp-ci-bot

kcp-ci-bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot

kcp-ci-bot commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: a4b55887a961fcb735a733e656779277adde28c9

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@kcp-ci-bot kcp-ci-bot merged commit f11df79 into kcp-dev:main Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embik embik embik approved these changes

Assignees

@embik embik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mirzakopic @kcp-ci-bot @embik