Skip to content

feat: add ssh to final kcl image#271

Merged
Peefy merged 1 commit intokcl-lang:mainfrom
paulorfjesus:patch-1
Oct 14, 2025
Merged

feat: add ssh to final kcl image#271
Peefy merged 1 commit intokcl-lang:mainfrom
paulorfjesus:patch-1

Conversation

@paulorfjesus
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #270

2. What is the scope of this PR (e.g. component or file name):

Dockerfile

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

KCL accordingly to documentation(https://www.kcl-lang.io/docs/user_docs/guides/package-management/how-to/kpm_git#add-a-git-repository-as-a-dependency) supports git dependencies using ssh but ssh don't exist in the image, so git clone with ssh fails

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

docker build

@Peefy Peefy merged commit 93bbeb4 into kcl-lang:main Oct 14, 2025
11 of 12 checks passed
@Peefy
Copy link
Contributor

Peefy commented Oct 14, 2025

Thank you! ♥

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18471572007

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.542%

Totals Coverage Status
Change from base Build 18333274348: 0.0%
Covered Lines: 99
Relevant Lines: 637

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kcl image dont have ssh - unable to download dependencies using git with ssh

3 participants