Skip to content

fix: rm the update of kcl.mod when 'kcl mod metadata'#188

Merged
zong-zhe merged 1 commit intomainfrom
rm-modfile-update
Dec 16, 2024
Merged

fix: rm the update of kcl.mod when 'kcl mod metadata'#188
zong-zhe merged 1 commit intomainfrom
rm-modfile-update

Conversation

@zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kcl#1789

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the bug Something isn't working label Dec 16, 2024
@zong-zhe zong-zhe requested a review from He1pa December 16, 2024 03:43
@zong-zhe zong-zhe self-assigned this Dec 16, 2024
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12345499090

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.542%

Totals Coverage Status
Change from base Build 12294629066: 0.0%
Covered Lines: 99
Relevant Lines: 637

💛 - Coveralls

@zong-zhe zong-zhe merged commit d6adc7b into main Dec 16, 2024
@Peefy Peefy deleted the rm-modfile-update branch December 16, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants