Skip to content

chore: add ca-certificates deps in the image#170

Merged
zong-zhe merged 1 commit intomainfrom
add-ca-certificates-in-image
Nov 15, 2024
Merged

chore: add ca-certificates deps in the image#170
zong-zhe merged 1 commit intomainfrom
add-ca-certificates-in-image

Conversation

@Peefy
Copy link
Contributor

@Peefy Peefy commented Nov 15, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re crossplane-contrib/function-kcl#191

  • chore: add ca-certificates deps in the image

Signed-off-by: Peefy <xpf6677@163.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11849140926

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 15.591%

Totals Coverage Status
Change from base Build 11797181889: 0.0%
Covered Lines: 99
Relevant Lines: 635

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 91e2f00 into main Nov 15, 2024
@Peefy Peefy deleted the add-ca-certificates-in-image branch November 20, 2024 02:21
@spastorclovr
Copy link

Hello,
When do you think this patch will be part of a a release? This is actually blocking as, since this morning at least, kcl modules cannot be downloaded from ghcr.io and I believe this is related to the certificates not being up-to-date.

failed to resolve 1.31.2: Get "https://ghcr.io/v2/kcl-lang/k8s/manifests/1.31.2": tls: failed to verify certificate: x509: certificate signed by unknown authority

Thx!

@Peefy
Copy link
Contributor Author

Peefy commented Nov 21, 2024

Hello @spastorclovr . Thanks for the feedback.

Just yesterday, I completed the testing of the new image and released v0.10.10. You can try it out.

@spastorclovr
Copy link

Thx for your reply @Peefy . Unless I am mistaken, the image does not seem to be pushed/available yet.

2024-11-21T07:46:15+01:00 DEBUG Image not found, pulling {"image": "xpkg.upbound.io/crossplane-contrib/function-kcl:v0.10.10"}
crossplane: error: cannot render composite resource: cannot start function runtimes: cannot start Function "kcl-function": cannot pull Docker image "xpkg.upbound.io/crossplane-contrib/function-kcl:v0.10.10": Error response from daemon: manifest for xpkg.upbound.io/crossplane-contrib/function-kcl:v0.10.10 not found: manifest unknown: manifest unknown

@Peefy
Copy link
Contributor Author

Peefy commented Nov 21, 2024

Thx for your reply @Peefy . Unless I am mistaken, the image does not seem to be pushed/available yet.

Sorry, I just released kcllang/kcl:v0.10.10, and now I have released xpkg.upbound.io/crossplane-contrib/function-kcl:v0.10.10

@spastorclovr
Copy link

Thx a bunch @Peefy . It now works perfectly with latest crossplane-contrib/function-kcl:v0.10.10

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants