Skip to content

feat: make 'kcl mod add' supports ModSpec#164

Merged
zong-zhe merged 3 commits intomainfrom
add-mod-spec
Nov 8, 2024
Merged

feat: make 'kcl mod add' supports ModSpec#164
zong-zhe merged 3 commits intomainfrom
add-mod-spec

Conversation

@zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Nov 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kpm#289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe added the enhancement New feature or request label Nov 8, 2024
@zong-zhe zong-zhe requested a review from Peefy November 8, 2024 06:14
@zong-zhe zong-zhe self-assigned this Nov 8, 2024
Signed-off-by: zongz <zongzhe1024@163.com>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: zongz <zongzhe1024@163.com>
@zong-zhe zong-zhe merged commit 8402460 into main Nov 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11737937521

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.63%

Totals Coverage Status
Change from base Build 11723113428: 0.0%
Covered Lines: 91
Relevant Lines: 622

💛 - Coveralls

@Peefy Peefy deleted the add-mod-spec branch November 20, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants