You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Raise coverage of src/http/websocket_server.cpp from the 2026-04-26 baseline (line 39.9%, branch 19.7%) to line >= 70% and branch >= 60%, measured under the coverage workflow (all BUILD_WITH_* flags, lcov --rc lcov_branch_coverage=1).
Why
src/http/websocket_server.cpp sits among the lowest-coverage files in the network_system source tree per the 2026-04-26 measurement on develop @ 05c1b7bb.
The uncovered region concentrates in error and boundary paths -- exactly the surfaces that regress during the ongoing Result<T> migration and API stabilization.
Bringing this file over the 70% line / 60% branch bar contributes directly to the Expand unit test coverage from 40% to 80% #953 acceptance criteria (80% line / 70% branch ecosystem-wide).
Keep tests hermetic -- no network, no filesystem, no sleeps beyond a few ms for timer-driven code paths.
Run ASAN/TSAN/UBSAN locally (or rely on CI) before requesting review.
Acceptance Criteria
Current-baseline coverage for src/http/websocket_server.cpp recorded as an issue comment
src/http/websocket_server.cpp line coverage >= 70% on develop after merge
src/http/websocket_server.cpp branch coverage >= 60% on develop after merge
All tests pass on Ubuntu/macOS/Windows CI
ASAN, TSAN, UBSAN sanitizer jobs green
No regressions in overall network_system coverage
Out of Scope
Refactoring src/http/websocket_server.cpp beyond what is strictly needed to make paths testable (seam insertion is acceptable; behavior changes are not).
Integration or end-to-end tests -- those live in separate files and are tracked elsewhere.
Part of #953
What
Raise coverage of
src/http/websocket_server.cppfrom the 2026-04-26 baseline (line 39.9%, branch 19.7%) to line >= 70% and branch >= 60%, measured under the coverage workflow (allBUILD_WITH_*flags,lcov --rc lcov_branch_coverage=1).Why
src/http/websocket_server.cppsits among the lowest-coverage files in the network_system source tree per the 2026-04-26 measurement ondevelop @ 05c1b7bb.Result<T>migration and API stabilization.Where
src/http/websocket_server.cpp(308 instrumented lines)tests/unit/for an existing file that targets this translation unit; if none exists, create one following the naming convention used by recently-closed siblings (e.g. test(http2): expand branch coverage for hpack #1043, test(http2/hpack): expand coverage for hpack.cpp #1044, test(tcp): expand coverage for tcp_socket.cpp #1045, test(core): expand coverage for unified_session_manager.cpp #1046, test(quic): expand coverage for frame.cpp #1047).add_network_test(...)pattern intests/CMakeLists.txt.How
Approach
developHEAD and record in an issue comment before writing tests.Acceptance Criteria
src/http/websocket_server.cpprecorded as an issue commentsrc/http/websocket_server.cppline coverage >= 70% ondevelopafter mergesrc/http/websocket_server.cppbranch coverage >= 60% ondevelopafter mergeOut of Scope
src/http/websocket_server.cppbeyond what is strictly needed to make paths testable (seam insertion is acceptable; behavior changes are not).Dependencies