Skip to content

fix(deps): Add benchmark 1.8.3 override to vcpkg.json #564

Description

@kcenon

Part of kcenon/common_system#454

What

Add benchmark version 1.8.3 to the vcpkg.json overrides array. All 7 other ecosystem systems pin benchmark to 1.8.3, but monitoring_system does not.

  • Current: overrides contains grpc (1.51.1), protobuf (3.21.12), gtest (1.14.0) — no benchmark
  • Expected: overrides also includes { "name": "benchmark", "version": "1.8.3" }
  • Scope: vcpkg.json overrides section only

Why

  • monitoring_system uses the testing feature which pulls in Google Benchmark
  • All 7 peer systems (common, thread, logger, container, database, network, pacs) pin benchmark to 1.8.3
  • Without the override, vcpkg may resolve a different benchmark version, causing potential ABI mismatch when monitoring_system is linked alongside other ecosystem libraries in a consumer project
  • Ecosystem standard defined in DEPENDENCY_MATRIX.md: benchmark 1.8.3

Where

  • vcpkg.json line ~17: after the existing gtest override entry

How

Technical Approach

Add one entry to the overrides array:

"overrides": [
    { "name": "grpc", "version": "1.51.1" },
    { "name": "protobuf", "version": "3.21.12" },
    { "name": "gtest", "version": "1.14.0" },
    { "name": "benchmark", "version": "1.8.3" }
]

Acceptance Criteria

  • benchmark override at version 1.8.3 is present in vcpkg.json
  • No other overrides are modified
  • vcpkg install resolves without version conflict warnings

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions