Skip to content

fix(ci): Strengthen vcpkg consumer test to detect missing find_package() targets #555

Description

@kcenon

What

Update the vcpkg consumer integration test to use REQUIRED for all find_package() calls so CI fails when a package cannot be found, instead of silently skipping.

  • Current: Only common_system uses REQUIRED; other 7 systems use optional find_package() that silently skip on failure
  • Expected: All 8 systems use REQUIRED so CI catches find_package() naming mismatches
  • Scope: integration_tests/vcpkg_consumer/CMakeLists.txt

Why

  • The current consumer test created a false positive in CI: 4 systems (logger, container, database, network) could not be found via snake_case find_package(), but CI still passed
  • This masked the find_package() naming issue introduced in PR fix(vcpkg-ports): sync all overlay ports with vcpkg-registry #553
  • A deployment-readiness test that silently accepts failures provides no value

Where

  • integration_tests/vcpkg_consumer/CMakeLists.txt — lines 20-91

How

Technical Approach

Change all find_package({name} CONFIG) calls to find_package({name} CONFIG REQUIRED) and remove the conditional if({name}_FOUND) blocks.

Acceptance Criteria

  • All 8 find_package() calls use REQUIRED
  • CI fails if any package cannot be found
  • Consumer binary links all 8 libraries unconditionally

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority/highHigh priority - Critical for productionsize/SSmall - Less than 1 day of worktype/fixBug fixes and corrections

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions