refactor(collectors): use KCENON_WITH_MONITORING_SYSTEM from feature_flags#164
Merged
Merged
Conversation
…flags Replace BUILD_WITH_MONITORING_SYSTEM with KCENON_WITH_MONITORING_SYSTEM to align monitoring integration gates with the unified macro set from common_system. Changes: - Include feature_flags.h in message_bus_collector headers - Replace #ifdef BUILD_WITH_MONITORING_SYSTEM with #if KCENON_WITH_MONITORING_SYSTEM - Update CMakeLists.txt to define WITH_MONITORING_SYSTEM instead of BUILD_WITH_MONITORING_SYSTEM (feature_flags.h uses this to set KCENON_WITH_MONITORING_SYSTEM) - Update cmake/UnifiedDependencies.cmake similarly Closes #163
Update documentation to reference the new KCENON_WITH_MONITORING_SYSTEM macro instead of BUILD_WITH_MONITORING_SYSTEM.
… IExecutor support The thread_pool class conditionally inherits from IExecutor interface only when KCENON_HAS_COMMON_EXECUTOR=1 is defined. Without this definition, standalone_backend::get_executor() fails to compile because shared_ptr<thread_pool> cannot be converted to shared_ptr<IExecutor>. This fix enables the IExecutor interface inheritance in thread_pool when common_system is linked, allowing proper type conversion in standalone_backend.
…ECUTOR fix - Add changelog entry for the IExecutor support build fix - Document KCENON_HAS_COMMON_EXECUTOR prerequisite in integration README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
#ifdef BUILD_WITH_MONITORING_SYSTEMwith#if KCENON_WITH_MONITORING_SYSTEMTest plan
Closes #163