You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apply corrective patches for any deviations surfaced by the standard-conformance audit (sibling sub-issue) or the cmake template alignment (sibling sub-issue).
Status: created proactively. Will be closed without action if both sibling audits report zero must-fix deviations.
Current: Unknown until the two sibling audits finish. Reconnaissance flags two candidates (do not pre-judge — the audit is authoritative):
src/impl/**/*.h headers — verify these are correctly internal, not a public-header leak under src/
cmake module count vs canonical template — logger_system has 6 logger_*.cmake; the template defines more
Expected: Either zero patches needed (issue closed with rationale) or a focused PR per deviation cluster, each linking back to the audit row that prompted it.
Scope: Whatever the two audits identify as must-fix. Anything classified accepted or informational is out of scope.
Wait for the two sibling audits (standard-conformance + cmake template alignment) to post their reports.
For each must-fix row in either audit:
Open a focused branch from develop, name e.g. chore/issue-<this>-<short-tag>
Make the minimum change required to resolve the deviation
Reference the audit row in the commit message and PR body
Squash merge to develop
If both audits report zero must-fix deviations, close this issue with a comment linking the two audit reports and noting "no corrective work required".
Acceptance Criteria
Either: every must-fix row from sibling audits is resolved by a merged PR linked to this issue
Or: this issue is closed with a comment confirming both audits found zero must-fix deviations
Patches preserve the public API (forwarding headers [[deprecated]] for one release per master EPIC #657 risk mitigation)
No drive-by refactoring — each PR touches only the lines required by its audit row
What
Apply corrective patches for any deviations surfaced by the standard-conformance audit (sibling sub-issue) or the cmake template alignment (sibling sub-issue).
Status: created proactively. Will be closed without action if both sibling audits report zero must-fix deviations.
src/impl/**/*.hheaders — verify these are correctly internal, not a public-header leak undersrc/logger_systemhas 6logger_*.cmake; the template defines moremust-fix. Anything classifiedacceptedorinformationalis out of scope.Why
Part of #624.
How
Technical Approach
must-fixrow in either audit:develop, name e.g.chore/issue-<this>-<short-tag>developmust-fixdeviations, close this issue with a comment linking the two audit reports and noting "no corrective work required".Acceptance Criteria
must-fixrow from sibling audits is resolved by a merged PR linked to this issuemust-fixdeviations[[deprecated]]for one release per master EPIC #657 risk mitigation)