Skip to content

chore(patches): corrective patches for audit deviations (conditional) #630

Description

@kcenon

What

Apply corrective patches for any deviations surfaced by the standard-conformance audit (sibling sub-issue) or the cmake template alignment (sibling sub-issue).

Status: created proactively. Will be closed without action if both sibling audits report zero must-fix deviations.

  • Current: Unknown until the two sibling audits finish. Reconnaissance flags two candidates (do not pre-judge — the audit is authoritative):
    • src/impl/**/*.h headers — verify these are correctly internal, not a public-header leak under src/
    • cmake module count vs canonical template — logger_system has 6 logger_*.cmake; the template defines more
  • Expected: Either zero patches needed (issue closed with rationale) or a focused PR per deviation cluster, each linking back to the audit row that prompted it.
  • Scope: Whatever the two audits identify as must-fix. Anything classified accepted or informational is out of scope.

Why

  • Closing [EPIC] logger_system: final standard verification #624 requires either zero deviations or each deviation explicitly accepted. Patches are the mechanism for "must-fix" rows.
  • Tracking corrective work in a dedicated issue keeps the audit issues read-only and gives PRs a clean issue to link.
  • Existing proactively (rather than created reactively after the audit) means there is no scheduling delay between audit and remediation.

Part of #624.

How

Technical Approach

  1. Wait for the two sibling audits (standard-conformance + cmake template alignment) to post their reports.
  2. For each must-fix row in either audit:
    • Open a focused branch from develop, name e.g. chore/issue-<this>-<short-tag>
    • Make the minimum change required to resolve the deviation
    • Reference the audit row in the commit message and PR body
    • Squash merge to develop
  3. If both audits report zero must-fix deviations, close this issue with a comment linking the two audit reports and noting "no corrective work required".

Acceptance Criteria

  • Either: every must-fix row from sibling audits is resolved by a merged PR linked to this issue
  • Or: this issue is closed with a comment confirming both audits found zero must-fix deviations
  • Patches preserve the public API (forwarding headers [[deprecated]] for one release per master EPIC #657 risk mitigation)
  • No drive-by refactoring — each PR touches only the lines required by its audit row

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:highHigh priority issuerefactoringCode refactoring and improvements

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions