You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verify that logger_system's cmake/*.cmake decomposition matches the canonical template documented in kcenon-system-layout.md v1.0.
Current: logger_system/cmake/ holds 6 logger_*.cmake modules (logger_compatibility, logger_coverage, logger_dependencies, logger_features, logger_sanitizers, logger_warnings) plus 3 shared/build helpers (CompilerChecks, FetchBenchmark, UnifiedDependencies) and the install config logger_system-config.cmake.in. The parent EPIC [EPIC] logger_system: final standard verification #624 references "logger has 7 modules" and notes the canonical template defines 8.
Expected: Each module in the canonical template either has a matching module in logger_system/cmake/ or is documented as an explicit, accepted deviation (with rationale).
The whole point of the cmake-template extraction in Phase 0 is to give all 8 systems a comparable, reviewable build configuration. Drift in logger_system undermines the template's value as a reference.
logger_system is intended as a reference example; reviewers and contributors should be able to use its cmake/ directory as a worked instance of the template.
Catching template gaps here is cheaper than discovering them when a future system tries to copy logger_system's layout.
What
Verify that
logger_system'scmake/*.cmakedecomposition matches the canonical template documented inkcenon-system-layout.mdv1.0.logger_system/cmake/holds 6logger_*.cmakemodules (logger_compatibility,logger_coverage,logger_dependencies,logger_features,logger_sanitizers,logger_warnings) plus 3 shared/build helpers (CompilerChecks,FetchBenchmark,UnifiedDependencies) and the install configlogger_system-config.cmake.in. The parent EPIC [EPIC] logger_system: final standard verification #624 references "logger has 7 modules" and notes the canonical template defines 8.logger_system/cmake/or is documented as an explicit, accepted deviation (with rationale).Why
logger_systemundermines the template's value as a reference.logger_systemis intended as a reference example; reviewers and contributors should be able to use itscmake/directory as a worked instance of the template.logger_system's layout.Part of #624.
How
Technical Approach
Pull the canonical template module list from
kcenon-system-layout.mdv1.0 and from thepacs_systemreference layout.Build a mapping table:
<system>_featureslogger_features.cmakeClassify each row:
match— name and contents align (verify by reading both files)missing— template defines a module logger_system lacks; decide whether to add or acceptextra— logger_system has a module the template does not; document rationale (e.g.logger_compatibility.cmake)renamed— same purpose, different name; align if cheapPost the mapping table as a comment on this issue.
If any
missingorrenamedrows require code changes, open them under the corrective-patches sub-issue.Acceptance Criteria
logger_system/cmake/logger_*.cmakeposted as a commentmissingrow has a disposition (add / accept with rationale)extrarow has a documented rationale (e.g.logger_compatibility.cmakejustification)CMakeLists.txtinclude(...)directives match the final module list (no orphaned modules, no missing includes)