Skip to content

chore(audit): standard-conformance audit of logger_system layout #627

Description

@kcenon

What

Conduct a final standard-conformance audit of logger_system against the published kcenon-system-layout.md v1.0.

  • Current: logger_system is reported to follow the ecosystem standard closely, but no formal deviation report exists. Reconnaissance has surfaced two candidates worth verifying explicitly:
    • src/impl/**/*.h retains internal headers under src/ — confirm none of these are part of the public surface
    • include/kcenon/logger/ reaches 8-segment depth in places (e.g. core/strategies/, core/metrics/) — verify against the standard's depth/naming rules
  • Expected: An audit report (attached as a comment on this issue and [EPIC] logger_system: final standard verification #624) that lists every candidate deviation, classifies each as accepted / must-fix / informational, and links any required corrective work to a follow-up issue.
  • Scope: Read-only inspection of include/, src/, tests/, integration_tests/. No code changes in this issue.

Why

  • The master EPIC [EPIC] Ecosystem-wide directory structure standardization common_system#657 cannot close until every system has either zero deviations or each deviation explicitly accepted.
  • logger_system is intended to be a reference example alongside pacs_system and common_system; an audit gives downstream consumers a documented baseline.
  • Catching small drift now informs whether the standard document itself needs amendment before phase rollout completes.

Part of #624.

How

Technical Approach

  1. Read kcenon-system-layout.md v1.0 and extract the conformance rules into a checklist.
  2. For each rule, verify against logger_system and record:
    • Rule ID
    • Status: pass / deviation / n/a
    • Evidence (path or snippet)
    • Disposition: accepted (with rationale) / must-fix (link follow-up issue) / informational
  3. Pay particular attention to:
    • include/kcenon/logger/ naming and depth rules (subdir count, max depth)
    • Whether src/impl/**/*.h qualifies as a public-header leak or is correctly internal
    • tests/ vs integration_tests/ separation
    • cmake module decomposition (handled separately in the cmake-alignment sub-issue)
  4. Post the audit report as a comment on this issue and on the parent EPIC [EPIC] logger_system: final standard verification #624.

Acceptance Criteria

Metadata

Metadata

Assignees

No one assigned

    Labels

    architectureArchitectural changes and designpriority:highHigh priority issuerefactoringCode refactoring and improvements

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions