You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Static audit performed during thread_system EPIC kcenon/thread_system#683 (sub-issue #687, downstream consumer verification) found a stale include in logger_system that is unrelated to the include-layout standardization but should be addressed.
thread_system removed interfaces/monitorable_interface.h in PR #312 / #323 (Dec 19, 2025) as part of the migration to common::interfaces::IMonitor. logger_system still references this header behind a #ifdef USE_THREAD_SYSTEM gate, so it is dormant in the default build but will fail to compile if LOGGER_USE_THREAD_SYSTEM=ON and USE_THREAD_SYSTEM is defined.
What
The following include refers to a header that no longer exists in thread_system:
No source files in logger_system reference the removed <kcenon/thread/interfaces/monitorable_interface.h>
Building logger_system with LOGGER_USE_THREAD_SYSTEM=ON and a thread_system install that defines USE_THREAD_SYSTEM succeeds without missing-header errors
If the adapter is kept, it consumes common::interfaces::IMonitor instead of the removed thread_system interface
Notes
This issue is informational from the perspective of thread_system EPIC #683: the EPIC neither introduced nor caused this stale include. The forwarding-header strategy in PR #688 only affects the <utilities/...> and <core/{base,sync}/...> legacy paths, not deleted headers.
All other thread_system include sites in logger_system already use canonical <kcenon/thread/...> paths and are unaffected by EPIC #683.
Why
Static audit performed during
thread_systemEPIC kcenon/thread_system#683 (sub-issue #687, downstream consumer verification) found a stale include inlogger_systemthat is unrelated to the include-layout standardization but should be addressed.thread_systemremovedinterfaces/monitorable_interface.hin PR #312 / #323 (Dec 19, 2025) as part of the migration tocommon::interfaces::IMonitor.logger_systemstill references this header behind a#ifdef USE_THREAD_SYSTEMgate, so it is dormant in the default build but will fail to compile ifLOGGER_USE_THREAD_SYSTEM=ONandUSE_THREAD_SYSTEMis defined.What
The following include refers to a header that no longer exists in
thread_system:src/impl/monitoring/thread_system_monitor_adapter.h:21#include <kcenon/thread/interfaces/monitorable_interface.h><kcenon/common/interfaces/monitoring_interface.h>and migrate the adapter tocommon::interfaces::IMonitorRecommended action: either
thread_system_monitor_adapter.hto thecommon_systemIMonitorinterface (matches the upstream migration), or#ifdef USE_THREAD_SYSTEMgate suggests it was already deprecated for default builds).Where
src/impl/monitoring/thread_system_monitor_adapter.hAcceptance Criteria
logger_systemreference the removed<kcenon/thread/interfaces/monitorable_interface.h>logger_systemwithLOGGER_USE_THREAD_SYSTEM=ONand athread_systeminstall that definesUSE_THREAD_SYSTEMsucceeds without missing-header errorscommon::interfaces::IMonitorinstead of the removed thread_system interfaceNotes
thread_systemEPIC #683: the EPIC neither introduced nor caused this stale include. The forwarding-header strategy in PR #688 only affects the<utilities/...>and<core/{base,sync}/...>legacy paths, not deleted headers.logger_systemalready use canonical<kcenon/thread/...>paths and are unaffected by EPIC #683.thread_systemPR feat(structured): Phase 3.1 Structured Logging API Design #312 (commit 22ce1a61).