What
Rename common_systemConfig.cmake.in to common_system-config.cmake.in (kebab-case) for consistency with the other 6 ecosystem libraries.
Current State
| Library |
Config Template Naming |
Convention |
| common_system |
common_systemConfig.cmake.in |
PascalCase |
| thread_system |
thread_system-config.cmake.in |
kebab-case ✅ |
| logger_system |
logger_system-config.cmake.in |
kebab-case ✅ |
| container_system |
container_system-config.cmake.in |
kebab-case ✅ |
| monitoring_system |
monitoring_system-config.cmake.in |
kebab-case ✅ |
| database_system |
database_system-config.cmake.in |
kebab-case ✅ |
| network_system |
network_system-config.cmake.in |
kebab-case ✅ |
| pacs_system |
pacs_systemConfig.cmake.in |
PascalCase |
Why
- 8 libraries in the ecosystem should follow a single naming convention for maintainability
- kebab-case is the majority convention (6 of 8 libraries)
- CMake
find_package(CONFIG) searches for both <pkg>Config.cmake and <pkg>-config.cmake, so no downstream breakage
Where
| File |
Change |
cmake/common_systemConfig.cmake.in |
Rename to cmake/common_system-config.cmake.in |
CMakeLists.txt (lines 283-296) |
Update references from common_systemConfig to common_system-config and common_systemConfigVersion to common_system-config-version |
Note: Portfile CONFIG_PATH is directory-only (lib/cmake/common_system), no change needed.
How
Technical Approach
- Rename
cmake/common_systemConfig.cmake.in → cmake/common_system-config.cmake.in
- Update
CMakeLists.txt:
configure_package_config_file(): input/output filenameswrite_basic_package_version_file(): output filenameinstall(FILES ...): both config and version filenames
Acceptance Criteria
Related
What
Rename
common_systemConfig.cmake.intocommon_system-config.cmake.in(kebab-case) for consistency with the other 6 ecosystem libraries.Current State
common_systemConfig.cmake.inthread_system-config.cmake.inlogger_system-config.cmake.incontainer_system-config.cmake.inmonitoring_system-config.cmake.indatabase_system-config.cmake.innetwork_system-config.cmake.inpacs_systemConfig.cmake.inWhy
find_package(CONFIG)searches for both<pkg>Config.cmakeand<pkg>-config.cmake, so no downstream breakageWhere
cmake/common_systemConfig.cmake.incmake/common_system-config.cmake.inCMakeLists.txt(lines 283-296)common_systemConfigtocommon_system-configandcommon_systemConfigVersiontocommon_system-config-versionNote: Portfile
CONFIG_PATHis directory-only (lib/cmake/common_system), no change needed.How
Technical Approach
cmake/common_systemConfig.cmake.in→cmake/common_system-config.cmake.inCMakeLists.txt:configure_package_config_file(): input/output filenameswrite_basic_package_version_file(): output filenameinstall(FILES ...): both config and version filenamesAcceptance Criteria
find_package(common_system CONFIG)works correctly after changeRelated