kata-manager: do not depend on git,go or local repos by marcov · Pull Request #829 · kata-containers/tests

marcov · 2018-10-19T17:57:48Z

Make kata-manager able to run on base non development systems,
where git, golang and kata local repos may not be available.

Fixes: #828

Signed-off-by: Marco Vedovati mvedovati@suse.com

marcov · 2018-10-19T18:07:02Z

/cc @grahamwhaley

jodh-intel

Thanks @marcov!

lgtm

jodh-intel · 2018-10-22T07:32:32Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


jodh-intel · 2018-10-22T07:33:09Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


cute! :)

Nit: Minor typo though as this should probably be downloaders_list (missing n)?

jodh-intel

Thanks @marcov!

lgtm

Tested successfully.

jodh-intel · 2018-10-22T08:00:05Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

jodh-intel · 2018-10-22T08:00:32Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

jodh-intel · 2018-10-22T08:00:53Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

jodh-intel · 2018-10-22T08:01:08Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

jodh-intel

Thanks @marcov!

Tested successfully.

lgtm

jodh-intel · 2018-10-22T08:06:18Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

jodh-intel · 2018-10-22T08:16:14Z

cmd/kata-manager/kata-manager.sh

 typeset -r default_config_file="/usr/share/defaults/kata-containers/${config_file_name}"
 typeset -r local_config_file="/etc/kata-containers/${config_file_name}"
+typeset -r kata_doc_to_script="${test_repo}/.ci/kata-doc-to-script.sh"
+typeset -r -A dowloaders_list=([curl]="-fsSL" [wget]="-O -")


Cute!

Nit: Typo as this should be downloaders_list presumably (missing n)?

chavafg

once the minor typo issue is fixed, this l g t m.
Tested on centos and works great 👍

Make kata-manager able to run on base non development systems, where git, golang and kata local repos may not be available. Fixes: kata-containers#828 Signed-off-by: Marco Vedovati <mvedovati@suse.com>

marcov · 2018-10-22T15:45:35Z

Glad to see this works for you too :)

I guess I can remove the WIP then,, and thanks for spotting the typo.

grahamwhaley

Interesting set of changes - funky use of bash array ;-)
lgtm

jodh-intel · 2018-10-23T09:11:25Z

/test

jodh-intel · 2018-10-23T14:52:53Z

Umm, not sure what happened here. I close the issue as I thought this PR was merged but github tells me I closed it?!?

I'm going to merge this with the following justification:

We must have a working installation method for new users.
@marcov, @chavafg and myself have tested this locally.
The kata-manager is only used by users and osbuilder so there is little point letting the CI chug through the PR as the change is effectively a NOP as far as this and the other code repos are concerned.

If there are issues, we can fixup in a follow-up PR. I'm about to re-test once it lands too and will report back here...

jodh-intel · 2018-10-23T15:01:49Z

Tested latest kata-manager using https://github.com/kata-containers/documentation/blob/master/install/installing-with-kata-manager.md on Ubuntu 16.04 and works a treat.

Hopefully, we'll get the automated CI tests on kata-containers/documentation#280 landed "real soon now" :)

marcov requested review from chavafg and jodh-intel and removed request for chavafg October 19, 2018 17:58

marcov mentioned this pull request Oct 19, 2018

install: clean instructions for kata-manager kata-containers/documentation#279

Merged

jodh-intel approved these changes Oct 22, 2018

View reviewed changes

chavafg reviewed Oct 22, 2018

View reviewed changes

marcov force-pushed the better-katamgr branch from 12b27d0 to 8fa76a4 Compare October 22, 2018 15:37

kata-manager: do not depend on git,go or local repos

1988d50

Make kata-manager able to run on base non development systems, where git, golang and kata local repos may not be available. Fixes: kata-containers#828 Signed-off-by: Marco Vedovati <mvedovati@suse.com>

marcov force-pushed the better-katamgr branch from 8fa76a4 to 1988d50 Compare October 22, 2018 15:37

marcov changed the title ~~[WIP] kata-manager: do not depend on git,go or local repos~~ kata-manager: do not depend on git,go or local repos Oct 22, 2018

jodh-intel mentioned this pull request Oct 23, 2018

CI: Test remaining install methods kata-containers/documentation#280

Merged

grahamwhaley approved these changes Oct 23, 2018

View reviewed changes

jodh-intel closed this Oct 23, 2018

jodh-intel mentioned this pull request Oct 23, 2018

kata-manager should be able to install Kata on non-development systems #828

Closed

jodh-intel reopened this Oct 23, 2018

jodh-intel merged commit 51a88ce into kata-containers:master Oct 23, 2018

Conversation

marcov commented Oct 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcov commented Oct 19, 2018

Uh oh!

jodh-intel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jodh-intel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jodh-intel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chavafg left a comment

Choose a reason for hiding this comment

Uh oh!

marcov commented Oct 22, 2018

Uh oh!

grahamwhaley left a comment

Choose a reason for hiding this comment

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018

Uh oh!

jodh-intel commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcov commented Oct 19, 2018 •

edited

Loading

jodh-intel commented Oct 23, 2018 •

edited

Loading