This repository was archived by the owner on Jun 28, 2024. It is now read-only.
CI: Add options to static-checks script#471
Merged
jodh-intel merged 9 commits intokata-containers:masterfrom Jul 4, 2018
Merged
CI: Add options to static-checks script#471jodh-intel merged 9 commits intokata-containers:masterfrom
jodh-intel merged 9 commits intokata-containers:masterfrom
Conversation
added 8 commits
July 3, 2018 11:07
Remove a stray code comment from the static-check script. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Rather than using comments, display a message so the caller can see whether some of the tests are running on `master` or their PR branch. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
The TODO/FIXME checker disabled on [1] needs an explicit skip message pointing at an issue URL to ensure we don't forget to re-enable it. --- [1] - kata-containers#464 Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Display a message when the repository is detected automatically. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Rather than just display the usage, display an informational message so the user knows they need to specify a repo URL. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add command-line options to all individual test functions in the `static-checks.sh` script to be run, rather than all of the tests. Fixes kata-containers#470. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add more examples to the usage statement for the static-checks script. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
Add a new "--force" option to override a skipped test. This is currently only useful to force the TODO/FIXME checker to run. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
grahamwhaley
approved these changes
Jul 3, 2018
| Usage: $script_name help | ||
| $script_name repo-name [true] | ||
| $script_name [options] repo-name [true] | ||
|
|
Contributor
There was a problem hiding this comment.
Somewhere, but I don't know where, we should probably try and note in the help that if you do not supply any options, then the default is 'all'. I don't think that is listed anywhere in the help?
Explain in the usage statement for the static-checks script that all tests will be run by default. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
sboeuf
approved these changes
Jul 3, 2018
This was referenced Jul 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add command-line options to all individual test functions in the
static-checks.shscript to be run, rather than all of the tests.Also includes commits for improved messages, and an explicit "skip" for the
TODO/FIXMEchecker that was disabled on #464.Fixes #470.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com