This repository was archived by the owner on Jun 28, 2024. It is now read-only.
tests: replace "/var/lib/vc" with "/run/vc"#2113
Merged
chavafg merged 1 commit intokata-containers:masterfrom Nov 22, 2019
Merged
tests: replace "/var/lib/vc" with "/run/vc"#2113chavafg merged 1 commit intokata-containers:masterfrom
chavafg merged 1 commit intokata-containers:masterfrom
Conversation
Fixes kata-containers#2112 Checking "/run/vc" can also get active pods so we don't have to use "/var/lib/vc", also I'm working on removing "/var/lib/vc" dir from persistent data, we should remove "/var/lib/vc" from tests repo first. Signed-off-by: Wei Zhang <weizhang555.zw@gmail.com>
Member
Author
|
/test |
grahamwhaley
approved these changes
Nov 22, 2019
Contributor
grahamwhaley
left a comment
There was a problem hiding this comment.
I've not checked the details of the relationship between our use of /var and /run, but presuming you are correct....
lgtm
| # This is ultimately what 'kata-runtime list' uses to get its info, but | ||
| # we can also check it for sanity directly | ||
| VC_POD_DIR="${VC_POD_DIR:-/var/lib/vc/sbs}" | ||
| VC_POD_DIR="${VC_POD_DIR:-/run/vc/sbs}" |
Contributor
There was a problem hiding this comment.
I was going to suggest we could change the code to get the directory from kata-runtime kata-env - but, I don't think we print that information (our workdir) in kata-env.... maybe we should? :-)
jodh-intel
approved these changes
Nov 22, 2019
chavafg
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2112
Checking "/run/vc" can also get active pods so we don't have to use
"/var/lib/vc", also I'm working on removing "/var/lib/vc" dir from
persistent data, we should remove "/var/lib/vc" from tests repo first.
Signed-off-by: Wei Zhang weizhang555.zw@gmail.com