Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

tests: Fix soak tests#1807

Merged
GabyCT merged 1 commit intokata-containers:masterfrom
GabyCT:topic/fixfcsoak
Jul 12, 2019
Merged

tests: Fix soak tests#1807
GabyCT merged 1 commit intokata-containers:masterfrom
GabyCT:topic/fixfcsoak

Conversation

@GabyCT
Copy link
Copy Markdown
Contributor

@GabyCT GabyCT commented Jul 11, 2019 •
edited
Loading

Instead of taking the full path name of the hypervisors, we need to change
to use only the name of the process as this will change once that we enable
jailer on firecracker.
Fixes #1804

Signed-off-by: Gabriela Cervantes gabriela.cervantes.tellez@intel.com

@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 6b9ea33 to 748c607 Compare July 11, 2019 20:02
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 748c607 to 6d22187 Compare July 11, 2019 20:35
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 6d22187 to e6fdb10 Compare July 11, 2019 21:14
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT GabyCT mentioned this pull request Jul 11, 2019
Closed
@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from e6fdb10 to f7fccd6 Compare July 11, 2019 21:54
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

so it looks like there is not finding the correct number of shims

16:44:57 ++ pgrep -a /usr/libexec/kata-containers/kata-shim
16:44:57 ++ wc -l
16:44:57 + how_many_shims=0
16:44:57 + ((  1 != 0  ))
16:44:57 + echo 'Wrong number of shims running (1 != 0) - stopping'
16:44:57 Wrong number of shims running (1 != 0) - stopping

/cc @grahamwhaley and @mcastelino

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from f7fccd6 to 032fd17 Compare July 11, 2019 22:07
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

ok found the issue of the shims...

@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 032fd17 to 863e5e3 Compare July 11, 2019 22:16
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 11, 2019

/test-fc

@GabyCT
tests: Fix soak tests
7714fc0 
Instead of taking the full path name of the hypervisors, we need to change
to use only the name of the process as this will change once that we enable
jailer on firecracker.

Fixes kata-containers#1804

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@grahamwhaley
Copy link
Copy Markdown
Contributor

grahamwhaley commented Jul 12, 2019

Looks like the fc CI passed, but I don't see any shim related changes in the commits I think - what did you find @GabyCT ? :-)

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 863e5e3 to 6d0770f Compare July 12, 2019 13:36
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 12, 2019

/test-fc

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 6d0770f to 96ea4ad Compare July 12, 2019 14:08
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 12, 2019

@grahamwhaley , it was a mistake that I did, I remove the -f but now everything seems that is working again so it seems that we can enable again the tests

@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 12, 2019

/test

@GabyCT GabyCT changed the title debug: Debug soak tests tests: Fix soak tests Jul 12, 2019
@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from 96ea4ad to d4c535f Compare July 12, 2019 14:46
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 12, 2019

/test

@GabyCT GabyCT force-pushed the topic/fixfcsoak branch from d4c535f to 7714fc0 Compare July 12, 2019 15:41
@GabyCT
Copy link
Copy Markdown
Contributor Author

GabyCT commented Jul 12, 2019

/test

mcastelino
mcastelino approved these changes Jul 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@mcastelino mcastelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabyCT GabyCT merged commit 10bdf73 into kata-containers:master Jul 12, 2019
@GabyCT GabyCT deleted the topic/fixfcsoak branch July 29, 2021 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mcastelino mcastelino mcastelino approved these changes

@devimc devimc devimc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

debug why soak test fails on CI with jailer and fc

4 participants

@GabyCT @grahamwhaley @mcastelino @devimc